Page MenuHomePhabricator
Create Task
Maniphest T277848

Create an action for the DateValueInput to call on user input
Closed, ResolvedPublic
Actions

Description

acceptance criteria:

  • sets the current parsed value to null -> component should show loader
  • talks to ParseValue and FormatValue repositories
  • commits the parsed Value to the store, if successful
  • commits an error to the store if not?
  • returns the formatted value from the API?
    • alternative: include this value in the store as well and display it from there

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Validate datatype time conditions on RunQuerywikidata/query-buildermaster+122 -2
Create action to handle value from datatype timewikidata/query-buildermaster+201 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Mar 19 2021, 9:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2021, 9:46 AM
Michael mentioned this in T277850: Create DateValueInput component.Mar 19 2021, 9:49 AM
Michael moved this task from Incoming to Ready to pick up on the Wikidata Query Builder board.Mar 19 2021, 2:57 PM
Michael claimed this task.Apr 1 2021, 5:09 PM
Michael moved this task from Ready to pick up to Doing on the Wikidata Query Builder board.
Restricted Application added a project: User-Michael. · View Herald TranscriptApr 1 2021, 5:09 PM
gerritbot added a comment.Apr 6 2021, 2:26 PM

Change 676456 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Create action to handle value from datatype time

https://gerrit.wikimedia.org/r/676456

gerritbot added a project: Patch-For-Review.Apr 6 2021, 2:26 PM
Michael moved this task from Doing to Peer Review on the Wikidata Query Builder board.Apr 6 2021, 2:42 PM
gerritbot added a comment.Apr 7 2021, 10:21 AM

Change 676456 merged by jenkins-bot:

[wikidata/query-builder@master] Create action to handle value from datatype time

https://gerrit.wikimedia.org/r/676456

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2021, 11:11 AM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata Query Builder board.Apr 7 2021, 10:40 PM
Michael moved this task from Test (Verification) to Doing on the Wikidata Query Builder board.Apr 8 2021, 3:48 PM
gerritbot added a comment.Apr 8 2021, 4:27 PM

Change 677966 had a related patch set uploaded (by Michael Große; author: Michael Große):

[wikidata/query-builder@master] Validate datatype time conditions on RunQuery

https://gerrit.wikimedia.org/r/677966

gerritbot added a project: Patch-For-Review.Apr 8 2021, 4:27 PM
Michael moved this task from Doing to Peer Review on the Wikidata Query Builder board.Apr 8 2021, 4:29 PM
Michael updated the task description. (Show Details)
gerritbot added a comment.Apr 8 2021, 7:20 PM

Change 677966 merged by jenkins-bot:

[wikidata/query-builder@master] Validate datatype time conditions on RunQuery

https://gerrit.wikimedia.org/r/677966

Michael closed this task as Resolved.Apr 9 2021, 10:42 AM
Michael moved this task from Peer Review to Done on the Wikidata Query Builder board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits