Page MenuHomePhabricator
Create Task
Maniphest T277893

[M] Error: All parameters are required and cannot be empty or zero at ThumbnailWidth
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.03.19?id=YeQlSngBfVMx58vqoG9S

Error: All parameters are required and cannot be empty or zero
at ThumbnailWidth URL1:31:854
at TWCP.calculateWidths URL1:43:478
at C.getLightboxImageWidths URL1:67:143
at C.getCurrentImageWidths URL1:67:531
at MMVP.resize URL1:107:285
at MMVP.setupEventHandlers/< URL1:120:41
at dispatch URL2:204:742
at add/elemData.handle URL2:201:388
at trigger URL2:250:596
at trigger/< URL2:251:572
at each URL2:140:2
at each URL2:138:2
at trigger URL2:251:543
at C.attach/< URL1:63:431
at exec URL1:6:1301

URL1: https://de.wikipedia.org/w/load.php?lang=de&modules=jquery.color%2Cfullscreen%2Cthrottle-debounce%2Ctipsy%7Cmmv&skin=vector&version=16g5o
URL2: https://de.wikipedia.org/w/load.php?lang=de&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.centralautologin%7Cext.cite.ux-enhancements%7Cext.cx.eventlogging.campaigns%7Cext.eventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.flaggedRevs.advanced%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Coojs%2Coojs-router%2Csite%7Cjquery.client%2Ccookie%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.ui.button%2Cicon%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cskins.vector.legacy.js%7Cuser.defaults&skin=vector&version=brwxb

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Err: param required cant be empty/0 ThumbnailWidthmediawiki/extensions/MultimediaViewermaster+2 -2
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Mar 19 2021, 5:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2021, 5:36 PM
Krinkle added a project: Structured Data Engineering.Mar 27 2021, 3:26 AM
Krinkle updated the task description. (Show Details)
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMar 27 2021, 3:26 AM
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Mar 27 2021, 3:26 AM
CBogen edited projects, added: Structured-Data-Backlog (Current Work); removed: Structured-Data-Backlog.Mar 30 2021, 4:39 PM
CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.
CBogen renamed this task from Error: All parameters are required and cannot be empty or zero at ThumbnailWidth to [M] Error: All parameters are required and cannot be empty or zero at ThumbnailWidth.Apr 7 2021, 4:53 PM
CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.Apr 7 2021, 4:59 PM
Umherirrender added a project: JavaScript.Apr 8 2021, 9:40 PM
AnneT claimed this task.May 12 2021, 6:36 PM
AnneT moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.May 12 2021, 6:41 PM
AnneT removed AnneT as the assignee of this task.Jun 10 2021, 4:42 PM
AnneT subscribed.
CBogen subscribed.Jul 12 2021, 4:32 PM

@AnneT since you're no longer working on this, should I move it back to Ready for Development, or has someone else picked it up from you? Thanks!

AnneT moved this task from Doing to Ready for Development on the Structured-Data-Backlog (Current Work) board.Jul 12 2021, 6:03 PM

Hey @CBogen, I don't believe anyone else has picked this up, so I've moved it back to Ready for Development. Sorry for missing that!

Seddon moved this task from Ready for Development to Doing on the Structured-Data-Backlog (Current Work) board.Aug 10 2021, 11:06 AM
Seddon subscribed.EditedAug 10 2021, 12:02 PM

Some notes on this so far

So the error is thrown in two places: mmv.model.ThumbnailWidth.js and mmv.model.Thumbnail.js.

ThumbnailWidth is called in mv.ThumbnailWidthCalculator.js in turn called by mmv.lightboxinterface.js

Thumbnail is called by mmv.provider.GuessedThumbnailInfo.js and mmv.provider.ThumbnailInfo.js

My gut tells me that the problems are being created by ThumbnailWidthCalculator.js since calculated width and height values for images with extreme ratios and low resolution can result in outputting 0px due to rounding down with Math.round. Inputs should always be 1px or greater and this should help solve some of the problems such as here.

I suspect though that there are other possible sources of bad data triggering this error here that are much more difficult to replicate consistently. Ticking this one off first is a good first step.

Seddon claimed this task.Aug 10 2021, 9:13 PM
gerritbot added a comment.Aug 24 2021, 3:02 PM

Change 714580 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MultimediaViewer@master] Err: param required cant be empty/0 ThumbnailWidth

https://gerrit.wikimedia.org/r/714580

gerritbot added a project: Patch-For-Review.Aug 24 2021, 3:02 PM
Seddon moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Aug 24 2021, 3:04 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Aug 26 2021, 10:02 AM
gerritbot added a comment.Aug 26 2021, 10:05 AM

Change 714580 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Err: param required cant be empty/0 ThumbnailWidth

https://gerrit.wikimedia.org/r/714580

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2021, 10:10 AM
Seddon added a comment.Aug 26 2021, 10:44 AM

Tested on beta commons and no issues seen at the moment and bug seems resolved.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 26 2021, 11:00 AM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Aug 26 2021, 9:48 PM
Etonkovidova closed this task as Resolved.Sep 4 2021, 12:40 AM
Etonkovidova subscribed.

Checked for wmf.21 - the error is not present.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits