Move for_wikis transform from backend to frontend
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	bd808
	Mar 19 2021, 10:01 PM

Description

Similar to T277235: Move icon transform from backend to frontend, the transformation of the database for_wikis collection to pretty strings by the GET /api/tools/ and GET /api/tools/{name} routes ends up making the output different than the output of /api/search/tools/ which complicates display of search vs direct records. It also means that the response from the /api/tools/* routes needs to be transformed back the "raw" state before it can be used for editing.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	toolinfo: Move for_wikis display transform to frontend	wikimedia/toolhub	main	+117 -172

Customize query in gerrit

Related Objects

Mentioned In: rWTHU7849259c8e3a: toolinfo: Move for_wikis display transform to frontend
Mentioned Here: T277235: Move icon transform from backend to frontend

Event Timeline

bd808 created this task.Mar 19 2021, 10:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2021, 10:02 PM

https://github.com/wikimedia/toolhub/blob/main/vue/src/components/search/FilterList.vue#L73-L104 is an existing recreation of the mappings on the UI side. The fix here may reuse this somehow and must replace it with a unified solution. We do not want multiple source of truth implementations of the display string mappings.

bd808 claimed this task.Mar 22 2021, 9:09 PM

bd808 triaged this task as High priority.

bd808 moved this task from Backlog to In Progress on the Toolhub board.

bd808 added a project: Developer-Advocacy (Jan-Mar 2021).

Restricted Application added a project: User-bd808. · View Herald TranscriptMar 22 2021, 9:10 PM

Change 674150 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[wikimedia/toolhub@main] toolinfo: Move for_wikis display transform to frontend

https://gerrit.wikimedia.org/r/674150

gerritbot added a project: Patch-For-Review.Mar 22 2021, 10:28 PM

bd808 moved this task from In Progress to Review on the Toolhub board.Mar 22 2021, 10:29 PM

Change 674150 merged by jenkins-bot:
[wikimedia/toolhub@main] toolinfo: Move for_wikis display transform to frontend

https://gerrit.wikimedia.org/r/674150

srishakatux mentioned this in rWTHU7849259c8e3a: toolinfo: Move for_wikis display transform to frontend.Mar 25 2021, 1:44 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2021, 2:10 AM

bd808 closed this task as Resolved.Mar 26 2021, 4:32 PM