Page MenuHomePhabricator

Address Voice and Tone issues in BetaFeatures
Closed, ResolvedPublic

Description

Targets
    Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/BetaFeatures
Found Occurrences  (12 usages found)
    extensions  (12 usages found)
        BetaFeatures  (12 usages found)
            includes  (11 usages found)
                BetaFeatures.php  (3 usages found)
                    37 global $wgBetaFeaturesWhitelist;
                    38 if ( is_array( $wgBetaFeaturesWhitelist ) && !in_array( $feature, $wgBetaFeaturesWhitelist ) ) {
                    39 // If there is a whitelist, and the feature is not whitelisted,
                BetaFeaturesHooks.php  (6 usages found)
                    105 global $wgBetaFeaturesWhitelist, $wgBetaFeatures, $wgHiddenPrefs;
                    156 // Check if feature is whitelisted
                    158 is_array( $wgBetaFeaturesWhitelist ) &&
                    159 !in_array( $key, $wgBetaFeaturesWhitelist )
                    283 // @deprecated since 1.35, use unsupportedList instead of blacklist
                    284 ( $prefs[$key]['requirements']['blacklist'] ?? null );
                HTMLFeatureField.php  (2 usages found)
                    149 // @deprecated since 1.35, use unsupportedList instead of blacklist
                    150 ( $this->mParams['requirements']['blacklist'] ?? false );
            extension.json  (1 usage found)
                15 "BetaFeaturesWhitelist": {

Event Timeline

Hi @Reedy! In your opinion, How big is the size of this task (Small, medium, large, extra-large?

The numbers above should allow to judge. Hard to say without any criteria what's "small" or "large"? :)

It's not a lot of work, but it will need changes in a few steps (over probably a few weeks).

New variables need adding, plubming in. It needs reviewing, merging and eventually deploying via the train. When it's everywhere, the WMF config needs updating, and then sometime after that, the old variables should be removed.

And then there's any relevant (onwiki etc) documentation that may or may not need cleaning up too.

@Aklapper
Extra-small: 1 day (a few hours)
Small = 2–5 days
Medium = 6–20 days
Large = 10–20 days.
Extra Large: 21- 30 days

I'm a project manager working with the OKR: Removing non-inclusive language. And I'm taking @Reedy 's Parent task T254646 Reconsidering how we name things, as a starting point. I'd like to classify the tasks into XS; small, medium, large, and extra-large to invite more people interested to take action and solve the XS and S tasks. Thanks a lot for your input/feedback

@JArguello-WMF: Argh, I wasn't aware. I am sorry! Thanks for the explanation / additional context!

Change 881903 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/BetaFeatures@master] Replace wgBetaFeaturesWhitelist with wgBetaFeaturesAllowList

https://gerrit.wikimedia.org/r/881903

Change 881904 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/BetaFeatures@master] Drop legacy wgBetaFeaturesWhitelist setting

https://gerrit.wikimedia.org/r/881904

Change 881905 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/BetaFeatures@master] Drop legacy blacklist preference-matching setting

https://gerrit.wikimedia.org/r/881905

Change 881903 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Replace wgBetaFeaturesWhitelist with wgBetaFeaturesAllowList

https://gerrit.wikimedia.org/r/881903

Change 890893 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Flow@master] Hooks::isBetaFeatureAvailable: Use non-deprecated BetaFeaturesAllowList pref

https://gerrit.wikimedia.org/r/890893

Change 890893 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Hooks::isBetaFeatureAvailable: Use non-deprecated BetaFeaturesAllowList pref

https://gerrit.wikimedia.org/r/890893

Change 881904 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Drop legacy wgBetaFeaturesWhitelist setting

https://gerrit.wikimedia.org/r/881904

Change 881905 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Drop legacy blacklist preference-matching setting

https://gerrit.wikimedia.org/r/881905