Page MenuHomePhabricator

Address Voice and Tone issues in Flow
Open, Needs TriagePublic

Description

Targets
    Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/Flow
Found Occurrences  (41 usages found)
    extensions  (41 usages found)
        Flow  (41 usages found)
            .phan  (2 usages found)
                config.php  (2 usages found)
                    25 '../../extensions/SpamBlacklist',
                    41 '../../extensions/SpamBlacklist',
            includes  (13 usages found)
                SpamFilter  (5 usages found)
                    SpamBlacklist.php  (5 usages found)
                        5 use BaseBlacklist;
                        14 class SpamBlacklist implements SpamFilter {
                        30 $spamObj = BaseBlacklist::getSpamBlacklist();
                        64 * Checks if SpamBlacklist is enabled.
                        69 return ExtensionRegistry::getInstance()->isLoaded( 'SpamBlacklist' );
                Hooks.php  (8 usages found)
                    706 global $wgFlowCoreActionWhitelist,
                    724 // hide all views unless whitelisted
                    726 if ( !in_array( $action, $wgFlowCoreActionWhitelist ) ) {
                    731 // hide all actions unless whitelisted
                    733 if ( !in_array( $action, $wgFlowCoreActionWhitelist ) ) {
                    1765 global $wgBetaFeaturesWhitelist, $wgFlowEnableOptInBetaFeature;
                    1767 ( !is_array( $wgBetaFeaturesWhitelist ) ||
                    1768 in_array( BETA_FEATURE_FLOW_USER_TALK_PAGE, $wgBetaFeaturesWhitelist ) );
            modules  (1 usage found)
                editor  (1 usage found)
                    editors  (1 usage found)
                        visualeditor  (1 usage found)
                            mw.flow.ve.Target.js  (1 usage found)
                                70 mw.flow.ve.Target.static.importRules.external.blacklist[ 'link/mwExternal' ] = false;
            tests  (21 usages found)
                phpunit  (21 usages found)
                    SpamFilter  (21 usages found)
                        SpamBlacklistTest.php  (21 usages found)
                            5 use BaseBlacklist;
                            7 use Flow\SpamFilter\SpamBlacklist;
                            15 * @covers \Flow\SpamFilter\SpamBlacklist
                            20 class SpamBlacklistTest extends PostRevisionTestCase {
                            22 * @var SpamBlacklist
                            27 * Spam blacklist regexes. Examples taken from:
                            29 * @see http://meta.wikimedia.org/wiki/Spam_blacklist
                            30 * @see http://en.wikipedia.org/wiki/MediaWiki:Spam-blacklist
                            32 private const BLACKLIST = [ '\b01bags\.com\b', 'sytes\.net' ];
                            35 * Spam whitelist regexes. Examples taken from:
                            37 * @see http://en.wikipedia.org/wiki/MediaWiki:Spam-whitelist
                            39 private const WHITELIST = [ 'a5b\.sytes\.net' ];
                            53 'revision with domain blacklisted as spam, but subdomain whitelisted' => [
                            80 $this->spamFilter = new SpamBlacklist;
                            82 $this->markTestSkipped( 'SpamBlacklist not enabled' );
                            85 $this->setMwGlobals( 'wgBlacklistSettings', [
                            89 BaseBlacklist::clearInstanceCache();
                            92 $this->insertPage( 'MediaWiki:Spam-blacklist', implode( "\n", self::BLACKLIST ) );
                            93 $this->insertPage( 'MediaWiki:Spam-whitelist', implode( "\n", self::WHITELIST ) );
                            95 // That only works if the spam blacklist is really reset
                            96 $instance = BaseBlacklist::getSpamBlacklist();
            .rubocop_todo.yml  (2 usages found)
                10 # Configuration parameters: Blacklist.
                11 # Blacklist: END, (?-mix:EO[A-Z]{1})
            container.php  (1 usage found)
                796 new Flow\SpamFilter\SpamBlacklist,
            extension.json  (1 usage found)
                922 "FlowCoreActionWhitelist": {

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
OpenNone

Event Timeline

Hi @Reedy ! I'm trying to use T-shirt sizes to measure the effort required for each task to invite folks at the WMF to join and send proposals of which ones they'd like to change. The purpose of this estimation is to help folks decide which ones they'd like to tackle by giving them information about the effort.

SizeTimeScore
XSAt Most 1 Hour0
SAt Most 1 Day1
MAt Most 3 Days3
LAt Most 5 Days5
XLNeeds Re-Eval9
?Unknown

For this specific task, T277941, What would you say the size is?