Page MenuHomePhabricator

Address Voice and Tone issues in GlobalBlocking
Closed, ResolvedPublic

Description

Summary

GlobalBlocking uses several occurences of the word whitelist. Ideally these should be replaced where possible to use a word that does not have the negative connotations

Acceptance criteria

  • All uses of the word whitelist are dropped/replaced from GlobalBlocking where this is feasible to do

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Remove globalblock-whitelist from GlobalBlocking settingsrepos/test-platform/catalyst/ci-charts!140jnucheT277942main
Remove globalblock-whitelist from GlobalBlocking settingsrepos/test-platform/catalyst/patchdemo!359mszwarcT277942main
Customize query in GitLab

Event Timeline

Hi @Reedy! I'm trying to use T-shirt sizes to measure the effort required for each task to invite folks at the WMF to join and send proposals of which ones they'd like to change by giving them information about the effort and any other info you render relevant.

SizeTimeScore
XSAt Most 1 Hour0
SAt Most 1 Day1
MAt Most 3 Days3
LAt Most 5 Days5
XLNeeds Re-Eval9
?Unknown

For this specific task, T259804, What would you say the size is?

Change #1248089 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Drop GlobalBlockLocalStatusLookup::getLocalWhitelistInfo

https://gerrit.wikimedia.org/r/1248089

Change #1248089 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Drop GlobalBlockLocalStatusLookup::getLocalWhitelistInfo

https://gerrit.wikimedia.org/r/1248089

Change #1281877 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Remove use of whitelist in comments and variable names

https://gerrit.wikimedia.org/r/1281877

Change #1281931 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Rename i18n to avoid use of "whitelist"

https://gerrit.wikimedia.org/r/1281931

Change #1281938 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Create globalblock-local-status right

https://gerrit.wikimedia.org/r/1281938

Change #1281877 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Remove use of whitelist in comments and variable names

https://gerrit.wikimedia.org/r/1281877

Change #1281938 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Create globalblock-local-status right

https://gerrit.wikimedia.org/r/1281938

Change #1281931 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Rename i18n to avoid use of "whitelist"

https://gerrit.wikimedia.org/r/1281931

Change #1292032 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Grant globalblock-local-status to groups with globalblock-whitelist

https://gerrit.wikimedia.org/r/1292032

Change #1292032 merged by jenkins-bot:

[operations/mediawiki-config@master] Grant globalblock-local-status to groups with globalblock-whitelist

https://gerrit.wikimedia.org/r/1292032

Mentioned in SAL (#wikimedia-operations) [2026-05-26T08:33:22Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:rOPUP1292032b061f|Grant globalblock-local-status to groups with globalblock-whitelist (T277942)]], [[gerrit:1290964|hCaptcha CommonSettings.php: Don't define sitekeys as config vars]]

Mentioned in SAL (#wikimedia-operations) [2026-05-26T08:35:20Z] <dreamyjazz@deploy1003> dreamyjazz: Backport for [[gerrit:rOPUP1292032b061f|Grant globalblock-local-status to groups with globalblock-whitelist (T277942)]], [[gerrit:1290964|hCaptcha CommonSettings.php: Don't define sitekeys as config vars]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-05-26T08:43:18Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:rOPUP1292032b061f|Grant globalblock-local-status to groups with globalblock-whitelist (T277942)]], [[gerrit:1290964|hCaptcha CommonSettings.php: Don't define sitekeys as config vars]] (duration: 09m 56s)

Change #1295413 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] GlobalBlockStatus: Define prefered English alias as GlobalBlockStatus

https://gerrit.wikimedia.org/r/1295413

Change #1295416 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Use the globalblock-local-status right over globalblock-whitelist

https://gerrit.wikimedia.org/r/1295416

Change #1295417 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Drop wpWhitelistStatus handling from SpecialGlobalBlockStatus

https://gerrit.wikimedia.org/r/1295417

Change #1295413 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] GlobalBlockStatus: Define prefered English alias as GlobalBlockStatus

https://gerrit.wikimedia.org/r/1295413

Change #1296582 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@wmf/1.47.0-wmf.5] Use the globalblock-local-status right over globalblock-whitelist

https://gerrit.wikimedia.org/r/1296582

Change #1295416 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use the globalblock-local-status right over globalblock-whitelist

https://gerrit.wikimedia.org/r/1295416

Change #1295417 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Drop wpWhitelistStatus handling from SpecialGlobalBlockStatus

https://gerrit.wikimedia.org/r/1295417

Change #1296582 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.47.0-wmf.5] Use the globalblock-local-status right over globalblock-whitelist

https://gerrit.wikimedia.org/r/1296582

Change #1296620 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] core-Permissions: Stop assigning unused globalblock-whitelist right

https://gerrit.wikimedia.org/r/1296620

Change #1296621 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Drop the globalblock-whitelist right

https://gerrit.wikimedia.org/r/1296621

Change #1297704 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@wmf/1.47.0-wmf.4] Use the globalblock-local-status right over globalblock-whitelist

https://gerrit.wikimedia.org/r/1297704

Change #1297704 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@wmf/1.47.0-wmf.4] Use the globalblock-local-status right over globalblock-whitelist

https://gerrit.wikimedia.org/r/1297704

Change #1296620 merged by jenkins-bot:

[operations/mediawiki-config@master] core-Permissions: Stop assigning unused globalblock-whitelist right

https://gerrit.wikimedia.org/r/1296620

Mentioned in SAL (#wikimedia-operations) [2026-06-04T14:06:17Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1297704|Use the globalblock-local-status right over globalblock-whitelist (T277942)]], [[gerrit:1296620|core-Permissions: Stop assigning unused globalblock-whitelist right (T277942)]]

Mentioned in SAL (#wikimedia-operations) [2026-06-04T14:08:21Z] <dreamyjazz@deploy1003> dreamyjazz: Backport for [[gerrit:1297704|Use the globalblock-local-status right over globalblock-whitelist (T277942)]], [[gerrit:1296620|core-Permissions: Stop assigning unused globalblock-whitelist right (T277942)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-06-04T14:13:03Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1297704|Use the globalblock-local-status right over globalblock-whitelist (T277942)]], [[gerrit:1296620|core-Permissions: Stop assigning unused globalblock-whitelist right (T277942)]] (duration: 06m 46s)

Change #1296621 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Drop the globalblock-whitelist right

https://gerrit.wikimedia.org/r/1296621

https://gitlab.wikimedia.org/repos/test-platform/catalyst/patchdemo/-/merge_requests/359 needs merging, but beyond that GlobalBlocking has had all the references we can remove without too much effort:

  • The global_block_whitelist table has previously been determined as too much effort to rename
  • There is a whitelist and dwhitelist log action, but these are likely too difficult to rename due to old entries still having these log action names

Therefore, I think we have done as much as we can to remove whitelist from the extension