Address Voice and Tone issues in RelatedArticles
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Reedy
	Mar 19 2021, 10:51 PM

Project Tags

Referenced Files

None

Subscribers

Description

Targets
    Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/RelatedArticles
Found Occurrences  (3 usages found)
    extensions  (3 usages found)
        RelatedArticles  (3 usages found)
            includes  (2 usages found)
                Hooks.php  (2 usages found)
                    66 * show it if the whitelist (`RelatedArticlesFooterWhitelistedSkins`
                    76 $skins = $config->get( 'RelatedArticlesFooterWhitelistedSkins' );
            extension.json  (1 usage found)
                159 "RelatedArticlesFooterWhitelistedSkins": {

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Remove RelatedArticlesFooterWhitelistedSkins	mediawiki/extensions/RelatedArticles	master	+1 -8
Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins	operations/mediawiki-config	master	+1 -1
Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins	mediawiki/extensions/RelatedArticles	master	+12 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T254646 Reconsidering how we name things
		Resolved		Jdrewniak	T277958 Address Voice and Tone issues in RelatedArticles

Event Timeline

Reedy created this task.Mar 19 2021, 10:51 PM

Reedy updated the task description. (Show Details)Mar 21 2021, 5:02 AM

Jdlrobson added a project: Web-Team-Backlog-Archived.Mar 23 2021, 7:31 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog-Archived board.

ovasileva triaged this task as Medium priority.Mar 25 2021, 9:14 AM

ovasileva edited projects, added: Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed: Web-Team-Backlog-Archived.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Mar 31 2021, 10:07 PM

Change 680812 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/RelatedArticles@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

https://gerrit.wikimedia.org/r/680812

Change 680813 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/RelatedArticles@master] Remove RelatedArticlesFooterWhitelistedSkins

https://gerrit.wikimedia.org/r/680813

Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Apr 19 2021, 6:02 PM

phuedx claimed this task.Apr 20 2021, 5:09 PM

ovasileva set the point value for this task to 3.Apr 20 2021, 5:38 PM

Change 680812 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

https://gerrit.wikimedia.org/r/680812

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 20 2021, 9:00 PM

Change 681598 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

https://gerrit.wikimedia.org/r/681598

Blocked on https://gerrit.wikimedia.org/r/680812 being deployed (latest is Thursday, 29th April).

Change 681598 abandoned by Phuedx:

[operations/mediawiki-config@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

Reason:

See I34519c75ba.

https://gerrit.wikimedia.org/r/681598

Jdlrobson mentioned this in T281547: TypeError: Cannot read property 'top' of undefined.Apr 30 2021, 10:46 PM

I will backport this at 4pm UTC.

I don't think there's anything to backport...? 1.37.0-wmf.3 is on every wiki, and stable. So it's just the config change to be deployed

I am deploying the config change at 4pm UTC in the backport window. Sorry for confusion.

Jdlrobson removed Jdlrobson as the assignee of this task.May 3 2021, 8:53 PM

Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

Mentioned in SAL (#wikimedia-operations) [2021-05-03T23:14:03Z] <urbanecm@deploy1002> sync-file aborted: 7c47ee17b3936fb1f79590187a9e0028276e4a9d: Replace $wgRelatedArticlesFooterWhitelistedSkins (T277958)¨ (duration: 00m 01s)

Mentioned in SAL (#wikimedia-operations) [2021-05-03T23:15:03Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 7c47ee17b3936fb1f79590187a9e0028276e4a9d: Replace $wgRelatedArticlesFooterWhitelistedSkins (T277958) (duration: 00m 57s)