Page MenuHomePhabricator

Address Voice and Tone issues in RelatedArticles
Open, MediumPublic3 Estimated Story Points

Description

Targets
    Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/RelatedArticles
Found Occurrences  (3 usages found)
    extensions  (3 usages found)
        RelatedArticles  (3 usages found)
            includes  (2 usages found)
                Hooks.php  (2 usages found)
                    66 * show it if the whitelist (`RelatedArticlesFooterWhitelistedSkins`
                    76 $skins = $config->get( 'RelatedArticlesFooterWhitelistedSkins' );
            extension.json  (1 usage found)
                159 "RelatedArticlesFooterWhitelistedSkins": {

Event Timeline

Change 680812 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/RelatedArticles@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

https://gerrit.wikimedia.org/r/680812

Change 680813 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/RelatedArticles@master] Remove RelatedArticlesFooterWhitelistedSkins

https://gerrit.wikimedia.org/r/680813

ovasileva set the point value for this task to 3.Tue, Apr 20, 5:38 PM

Change 680812 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

https://gerrit.wikimedia.org/r/680812

Change 681598 had a related patch set uploaded (by Phuedx; author: Phuedx):

[operations/mediawiki-config@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

https://gerrit.wikimedia.org/r/681598

Change 681598 abandoned by Phuedx:

[operations/mediawiki-config@master] Rename RelatedArticlesFooterWhitelistedSkins to RelatedArticlesFooterAllowedSkins

Reason:

See I34519c75ba.

https://gerrit.wikimedia.org/r/681598

Jdlrobson added subscribers: phuedx, Jdlrobson.

I will backport this at 4pm UTC.

I don't think there's anything to backport...? 1.37.0-wmf.3 is on every wiki, and stable. So it's just the config change to be deployed

I am deploying the config change at 4pm UTC in the backport window. Sorry for confusion.

Mentioned in SAL (#wikimedia-operations) [2021-05-03T23:14:03Z] <urbanecm@deploy1002> sync-file aborted: 7c47ee17b3936fb1f79590187a9e0028276e4a9d: Replace $wgRelatedArticlesFooterWhitelistedSkins (T277958)¨ (duration: 00m 01s)

Mentioned in SAL (#wikimedia-operations) [2021-05-03T23:15:03Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 7c47ee17b3936fb1f79590187a9e0028276e4a9d: Replace $wgRelatedArticlesFooterWhitelistedSkins (T277958) (duration: 00m 57s)

Change 680813 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Remove RelatedArticlesFooterWhitelistedSkins

https://gerrit.wikimedia.org/r/680813