Targets
Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/Wikibase
Found Occurrences (6 usages found)
extensions (6 usages found)
Wikibase (6 usages found)
client (1 usage found)
data-bridge (1 usage found)
.stylelintrc (1 usage found)
24 "unit-blacklist": null
lib (1 usage found)
packages (1 usage found)
README.md (1 usage found)
54 and update the `phpunit.xml.dist` to add `tests/` to the `WikibaseTests` test suite and `src/` to the filter whitelist.
repo (1 usage found)
includes (1 usage found)
ParserOutput (1 usage found)
FullEntityParserOutputGenerator.php (1 usage found)
168 // Sometimes extensions like SpamBlacklist might call getParserOutput
view (1 usage found)
lib (1 usage found)
wikibase-termbox (1 usage found)
src (1 usage found)
components (1 usage found)
LicenseAgreement.vue (1 usage found)
85 // A better approach (e.g. whitelisting elements from resetting, see
phpunit.xml.dist (2 usages found)
25 <whitelist addUncoveredFilesFromWhitelist="true">
40 </whitelist>Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Improve wording of a comment | wikibase/termbox | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T254646 Reconsidering how we name things | |||
| Open | None | T277971 Address Voice and Tone issues in Wikibase |
Event Timeline
Comment Actions
Change 673657 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikibase/termbox@master] Improve wording of a comment
Comment Actions
Change 673657 merged by jenkins-bot:
[wikibase/termbox@master] Improve wording of a comment
Comment Actions
Hi, @Reedy and @toan, I'm trying to use T-shirt sizes to measure the effort required for each task to invite folks at the WMF to join and decide which ones they'd like to tackle by giving them information about the effort and any other info you consider relevant.
| Size | Time | Score |
| XS | At Most 1 Hour | 0 |
| S | At Most 1 Day | 1 |
| M | At Most 3 Days | 3 |
| L | At Most 5 Days | 5 |
| XL | Needs Re-Eval | 9 |
| ? | Unknown | |
For this specific task, T277971, What would you say the size is?
Comment Actions
The stylelint one has been fixed in the meantime.
From looking at the description, all the remaining occurrences are either 1) upstream-syntax (phpunit) or 2) directly referencing upstream syntax or naming (SpamBlacklist, phpunit.xml's whitelist)
How do we move forward with this?
Comment Actions
I think as long as the first party ones are fixed, that's the main thing.
Tasks like T254650: Rename TitleBlacklist and T254649: Rename SpamBlacklist exist to fix those underlying issues, and as we normally would expect in our day to day development, when those tasks themselves are addressed, eventually there will be followup here, and in any other usages. Similar for documentation referring to how things are named in PHPUnit.
It was more of a case for ease that all matches were just dumped to the bugs.
If someone has double checked that no new instances (that again are first party, and can be fixed) have come in since this was filed, I think it's fine to close the task.
Comment Actions
Mh, I wonder if that would be something worth adding to the respective tests extending NoBadUsageTestBase, like ClientNoBadUsageTest etc. That way we can also reliably prevent that in the future. I'm curious what @Lucas_Werkmeister_WMDE thinks.
OTOH, NoBadUsageTestBase is intentionally ignoring comments, which we do want check as well in this case. 🤔
Comment Actions
I think NoBadUsageTestBase would work for cases where we want to prevent PHP things (e.g. DB_MASTER instead of DB_PRIMARY), but for such a general check, I’m not convinced it’s worth checking automatically.
Comment Actions
Makes sense, thanks!
Running a codesearch with the regex from the description does reveal new matches, but they are all in the two categories already mentioned above: phpunit XML syntax and the spam-blacklist name:
https://codesearch.wmcloud.org/things/?q=%28white%7Cblack%29%5B+%5C-%5D%3Flist&files=&excludeFiles=&repos=Extension%3AWikibase
(7 matching files total: 4 phpunit xml, 1 referencing phpunit xml, 2 in the rest-api mentioning error-codes from spam-blacklist)