Page MenuHomePhabricator

Address Voice and Tone issues in WikimediaEvents
Open, Stalled, Needs TriagePublic

Description

Targets
    Occurrences of '(white|black)[ \-]?list' in Directory /Users/reedy/PhpstormProjects/mediawiki/extensions/WikimediaEvents
Found Occurrences  (12 usages found)
    extensions  (12 usages found)
        WikimediaEvents  (12 usages found)
            includes  (8 usages found)
                PrefUpdateInstrumentation.php  (2 usages found)
                    77 'echo-notifications-blacklist' => self::VALUE_NEWLINE_COUNT,
                    78 'email-blacklist' => self::VALUE_NEWLINE_COUNT,
                WikimediaEventsHooks.php  (6 usages found)
                    691 if ( isset( $data['email-blacklist'] ) ) {
                    692 $event['emailsBefore'] = $data['email-blacklist']['before'];
                    693 $event['emailsAfter'] = $data['email-blacklist']['after'];
                    696 if ( isset( $data['echo-notifications-blacklist'] ) ) {
                    697 $event['notificationsBefore'] = $data['echo-notifications-blacklist']['before'];
                    698 $event['notificationsAfter'] = $data['echo-notifications-blacklist']['after'];
            tests  (4 usages found)
                phpunit  (4 usages found)
                    PrefUpdateInstrumentationTest.php  (4 usages found)
                        62 yield 'Add to email-blacklist' => [ $user, 'email-blacklist', "31\n4\n159", [
                        66 'property' => 'email-blacklist',
                        72 yield 'Clear email-blacklist' => [ $user, 'email-blacklist', "", [
                        76 'property' => 'email-blacklist',

Event Timeline

Krinkle changed the task status from Open to Stalled.EditedOct 30 2021, 1:07 AM
Krinkle added a project: Performance-Team.
Krinkle subscribed.

The two problematic labels fulfil external contracts, which the subtasks track. I don't expect patches just for this repo, but will leave open just in case something remains. Marking as stalled for triaging purposes.