Page MenuHomePhabricator

VisualEditor's Reference dialog sometimes fails to load on wikis with language variants
Closed, ResolvedPublicBUG REPORT

Description

  1. Open https://sr.wikipedia.org/w/index.php?title=ФК_Рома&oldid=23672850&veaction=edit
  2. Click the "Референца" (Cite) button in the toolbar

Instead of showing the dialog box all the dialog boxes on the page stop working until you reload it.

The web console shows the following error:

Uncaught Error: Expected [{"attributes":{"variantInfo":{"disabled":{"t":"UEFA.com"}}},"type":"mwLanguageVariantInline","annotations":["h101ed040e7c05548"]},{"type":"/mwLanguageVariantInline"}] but got [{"attributes":{"variantInfo":{"disabled":{"t":"UEFA.com"}},"originalVariantInfo":"{\"disabled\":{\"t\":\"UEFA.com\"}}"},"type":"mwLanguageVariantInline","annotations":["h101ed040e7c05548"]},{"type":"/mwLanguageVariantInline"}]
    checkEqualData https://sr.wikipedia.org/w/load.php?lang=sr&modules=ext.visualEditor.articleTarget,base,core,desktopArticleTarget,desktopTarget,diffing,icons,language,mediawiki,mwalienextension,mwcore,mwextensions,mwformatting,mwgallery,mwimage,mwlanguage,mwlink,mwmeta,mwsave,mwsignature,mwtransclusion,sanitize,switching,welcome|ext.visualEditor.core.desktop,utils|ext.visualEditor.mwextensions.desktop|ext.visualEditor.mwimage.core&skin=vector&version=1sy66:206

Event Timeline

Srdjan changed the subtype of this task from "Task" to "Bug Report".Mar 21 2021, 9:31 PM

Change 674924 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.dm.TreeModifier: Ignore 'originalVariantInfo' in checkEqualData()

https://gerrit.wikimedia.org/r/674924

Change 674924 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TreeModifier: Ignore 'originalVariantInfo' when validating linear data

https://gerrit.wikimedia.org/r/674924

Change 675583 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5196ceb1f)

https://gerrit.wikimedia.org/r/675583

Change 675583 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (5196ceb1f)

https://gerrit.wikimedia.org/r/675583