Page MenuHomePhabricator

Instrumentation: Verify existing workflows (help panel, post-edit dialog, HomepageModule)
Closed, ResolvedPublic

Description

The instrumentation that already tracks the user’s behavior on the newcomer homepage and in the suggested edits module should continue in the same way. The only difference should be that “add a link” should be a new task type that can be distinguished from the legacy link task.

Likewise for the help panel, which will contain guidance specific to “add a link”, the instrumentation should work the same way as for legacy suggested edits, except it will include an indicator for this new task type.

Likewise for the post-edit dialog, which should use the same instrumentation as it already does, except including an indicator for this new task type.

Event Timeline

@Etonkovidova would you be willing to take this on? I suppose the last item might need to wait for T269659: Add a link: post-edit dialog to be completed.

Since I moved it to QA column, assigning also to @Etonkovidova but let us know if you want us to do the initial verification.

Basically, the existing workflows should "just work" since this task type is registered like the others, so there is nothing I can think of from a development perspective that's needed before QA can happen.

I was checking HomepageModule, HelpPanel, EditAttemptStep, and NewcomerTask - all looks good so far.
Questions for @kostajh
(1) there are no events recorded for interactions with the Add link structured task intro tour?

(2) there are no events recorded for the Add link inspector?

Hi @Etonkovidova we haven't done the instrumentation for add link-specific features yet. My understanding is that a new schema has to be created first (T278177: Add a link: create new Schema).

Instrumentation tasks are tracked separately via T273827: Add a link: instrumentation.

To answer your questions specifically:
(1) Correct, events will be added via T278111: Instrumentation: Onboarding
(2) Correct, events will be added via T278116: Instrumentation: Link inspector

Thanks, @mewoph for clarifying! I mark this task as Resolved then.