Page MenuHomePhabricator
Create Task
Maniphest T278121

Move search-widget takeover & preference from WikibaseMediaInfo into MediaSearch extension
Closed, ResolvedPublic
Actions

Description

The code for making the top-right search widget currently lives in WikibaseMediaInfo, as does the preference that controls it.
The code has already been duplicated into MediaSearch, but is currently inactive (preference & relevant hooks missing from extension.json) because they conflict & cause errors.
When Extension:MediaSearch takes over what is currently served from WikibaseMediaInfo, that relevant code must be removed from WikibaseMediaInfo & activated in MediaSearch in order to complete that transition.

Details

SubjectRepoBranchLines +/-
Remove search widget takeover & preferencesmediawiki/extensions/WikibaseMediaInfowmf/1.37.0-wmf.7+6 -23
Enable search widget takeover & preferencemediawiki/extensions/MediaSearchmaster+8 -0
Remove search widget takeover & preferencesmediawiki/extensions/WikibaseMediaInfomaster+3 -31
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Mar 22 2021, 12:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2021, 12:57 PM
gerritbot added a comment.Mar 22 2021, 12:57 PM

Change 674010 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/MediaSearch@master] Enable search widget takeover & preference

https://gerrit.wikimedia.org/r/674010

gerritbot added a project: Patch-For-Review.Mar 22 2021, 12:57 PM
gerritbot added a comment.Mar 22 2021, 1:11 PM

Change 674015 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove search widget takeover

https://gerrit.wikimedia.org/r/674015

matthiasmullie moved this task from Incoming to Blocked on the Structured-Data-Backlog (Current Work) board.Mar 22 2021, 1:14 PM

This will be part of T265939

matthiasmullie mentioned this in T265939: Split MediaSearch out into its own extension.Mar 22 2021, 1:14 PM
gerritbot added a comment.May 26 2021, 6:30 PM

Change 674015 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Remove search widget takeover & preferences

https://gerrit.wikimedia.org/r/674015

gerritbot added a comment.May 26 2021, 6:52 PM

Change 674010 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Enable search widget takeover & preference

https://gerrit.wikimedia.org/r/674010

AnneT mentioned this in rEMEDf72cfc39e416: Enable search widget takeover & preference.May 26 2021, 6:54 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).May 26 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 7:11 PM
gerritbot added a comment.May 27 2021, 9:30 AM

Change 695836 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/WikibaseMediaInfo@wmf/1.37.0-wmf.7] Remove search widget takeover & preferences

https://gerrit.wikimedia.org/r/695836

gerritbot added a project: Patch-For-Review.May 27 2021, 9:30 AM
CBogen closed this task as Resolved.Jun 14 2021, 5:14 PM
CBogen claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL