Page MenuHomePhabricator

LSK or back key close the wrong popup when loading article
Open, MediumPublicBUG REPORT

Description

Steps to Reproduce

(Starting from article page)

  1. go to en/Cat article
  2. go to next page and select Felidae article preview popup
  3. change the internet throttling to the lowest one (Slow 3G)
  4. press enter (READ)
  5. Before finishing loading the new article, press LSK to close loading page
Actual Results
  1. The url is #/article/en/Felidae in the loading animation
  2. press LSK, it goes to search result screen
Expected Results
  1. The url should remain #/article/en/Cat in the loading animation
  2. Press LSK, it should go to the previous article, ideally at the same location within the article
NOTE: This is not just a quick fix of the LSK key event, it requires the change of how we play the loading element
NOTE: When it starts from search page, then it goes back to result screen (the current existing behaviour)
NOTE: The refresh feature during <Error/> should remain the functionality during this change
NOTE: goto anchor should remain works : goto.article(lang, [articleTitle, anchor], true), or change the way how it goes

Event Timeline

SBisson triaged this task as Medium priority.Mar 24 2021, 1:49 PM

Moving this ticket back to the Ready for dev, requires more time and effort to develop.


One possible solution : (buggy POC commit)

Moving all loading details from <Article /> into <ArticleLoading />,
let the <ArticleLoading/> be a fullscreen popup, it preloads all the article apis, handles error events too.

Search page and article page call the <ArticleLoading/> before go to a new article page.

hueitan updated the task description. (Show Details)
hueitan moved this task from Dev to Ready for Dev on the Inuka-Team (Kanban) board.
SBisson moved this task from Backlog to Bugs on the Inuka-Team board.