Page MenuHomePhabricator
Create Task
Maniphest T278181

MWException for Cargo when using apostrophe in table name
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Create a template for a Cargo table that includes a row with a word that has an apostrophe, in this case "King's rock" (see https://test3.miraheze.org/w/index.php?title=Template:Moves&action=edit)
  2. Create the Cargo template with ?action=recreatedata
  3. MWException occurs because of the apostrophe existing
[39350b6496152e62bce16352] /wiki/Special:CargoTables/Moves   MWException from line 405 of /srv/mediawiki/w/extensions/Cargo/includes/CargoUtils.php: Error: unclosed string literal.
/srv/mediawiki/w/extensions/Cargo/includes/CargoSQLQuery.php:545, /srv/mediawiki/w/extensions/Cargo/includes/CargoSQLQuery.php:691, /srv/mediawiki/w/extensions/Cargo/includes/specials/CargoTables.php:185, /srv/mediawiki/w/includes/specialpage/SpecialPage.php:600, /srv/mediawiki/w/includes/specialpage/SpecialPageFactory.php:635, /srv/mediawiki/w/includes/MediaWiki.php:307, /srv/mediawiki/w/includes/MediaWiki.php:940, /srv/mediawiki/w/includes/MediaWiki.php:543, /srv/mediawiki/w/index.php:53, /srv/mediawiki/w/index.php:46

MediaWiki: 1.35.1
PHP: 7.3.27-1~deb10u1 (fpm-fcgi)
MariaDB: 10.4.15-MariaDB-1:10.4.15+maria~buster-log

Details

SubjectRepoBranchLines +/-
Disallow single and double quotes in table and field namesmediawiki/extensions/Cargomaster+2 -2
Customize query in gerrit

Event Timeline

Reception123 created this task.Mar 22 2021, 8:33 PM
Restricted Application added a project: User-RhinosF1. · View Herald TranscriptMar 22 2021, 8:33 PM
Restricted Application added subscribers: RhinosF1, Aklapper. · View Herald Transcript
Yaron_Koren subscribed.Mar 22 2021, 10:22 PM

That's definitely a bug that should be fixed, although it really is better to avoid apostrophes in field names - running queries on such fields is always going to be a pain. Actually, maybe Cargo should just disallow apostrophes (and double quotes, for that matter) in field names.

RhinosF1 moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.Mar 22 2021, 11:00 PM
Aklapper edited projects, added affects-Miraheze; removed User-RhinosF1.Aug 15 2022, 1:19 PM
TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:36 PM
gerritbot added a comment.Jun 7 2023, 3:44 PM

Change 928094 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/Cargo@master] Disallow single and double quotes in table and field names

https://gerrit.wikimedia.org/r/928094

gerritbot added a project: Patch-For-Review.Jun 7 2023, 3:44 PM
gerritbot added a comment.Jun 7 2023, 4:11 PM

Change 928094 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Disallow single and double quotes in table and field names

https://gerrit.wikimedia.org/r/928094

Yaron_Koren closed this task as Resolved.Jun 7 2023, 4:17 PM
Yaron_Koren claimed this task.

Apostrophes are now disallowed, finally.

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2023, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL