Page MenuHomePhabricator
Create Task
Maniphest T278228

Remove zid from ZTypeRegistry's cache when a known ZType is deleted
Closed, ResolvedPublic
Actions

Description

Found when analyzing why local tests failed. When Z111 is deleted after each test suite, it disappears from the database but its ID remains in the ZTypeRegistry.

Added ZTypeRegistry::unregisterType to run on ZObject deletion.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add unregisterType to remove zid from ZTypeRegistry when ZObject is deletedmediawiki/extensions/WikiLambdamaster+41 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Mar 23 2021, 11:46 AM
gerritbot added a comment.Mar 23 2021, 11:47 AM

Change 674289 had a related patch set uploaded (by Genoveva Galarza; owner: Genoveva Galarza):
[mediawiki/extensions/WikiLambda@master] Add unregisterType to remove zid from ZTypeRegistry when ZObject is deleted

https://gerrit.wikimedia.org/r/674289

gerritbot added a project: Patch-For-Review.Mar 23 2021, 11:47 AM
GrounderUK subscribed.Mar 23 2021, 1:23 PM

Only for a built-in Z2?

GrounderUK renamed this task from Remove zid from ZTypeRegistry when ZObject is deleted to Remove zid from ZTypeRegistry when a built-in ZObject is deleted.Mar 23 2021, 2:32 PM
Jdforrester-WMF renamed this task from Remove zid from ZTypeRegistry when a built-in ZObject is deleted to Remove zid from ZTypeRegistry's cache when a known ZType is deleted.Mar 24 2021, 5:30 PM
DVrandecic moved this task from To Triage to Phase γ on the Abstract Wikipedia team board.Mar 24 2021, 5:30 PM
DVrandecic edited projects, added: Abstract Wikipedia team (Phase γ); removed: Abstract Wikipedia team.
DVrandecic triaged this task as Medium priority.Mar 24 2021, 5:58 PM
Jdforrester-WMF added a subtask: T273541: Provide a ZObjectStore DAO service based on Wikipage and use it exclusively.Mar 24 2021, 5:58 PM
Jdforrester-WMF added a project: WikiLambda.Mar 24 2021, 8:30 PM
Jdforrester-WMF closed this task as Resolved.Mar 26 2021, 4:02 PM
Jdforrester-WMF assigned this task to gengh.
Jdforrester-WMF closed subtask T273541: Provide a ZObjectStore DAO service based on Wikipage and use it exclusively as Resolved.
gerritbot added a comment.Mar 26 2021, 4:09 PM

Change 674289 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Add unregisterType to remove zid from ZTypeRegistry when ZObject is deleted

https://gerrit.wikimedia.org/r/674289

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits