Maniphest T278254

Rename where* methods in UserSelectQueryBuilder
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Mar 23 2021, 6:58 PM

Tags

Referenced Files

None

Subscribers

Description

UserSelectQueryBuilder has some wrappers for QueryBuilder::where methods, but they are called userIds, userNames etc. It should be called whereUserIds, whereUserNames etc.

No deprecation needed, but we need to check for extension usage. One known usage is GrowthExperiments.
Extension+core can be updated at the same time.

Details

	Subject	Repo	Branch	Lines +/-
	Rename where* methods in UserSelectQueryBuilder	mediawiki/core	master	+49 -13
	Update method calls when using UserSelectQueryBuilder	mediawiki/extensions/GrowthExperiments	master	+3 -3

Customize query in gerrit

Event Timeline

• Pchelolo created this task.Mar 23 2021, 6:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2021, 6:58 PM

daniel moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Jun 8 2021, 11:42 AM

• Pchelolo reassigned this task from Peter.ovchyn to tchin.Jul 29 2021, 6:13 PM

• Pchelolo added a subscriber: Peter.ovchyn.

Change 709779 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] Rename where* methods in UserSelectQueryBuilder

https://gerrit.wikimedia.org/r/709779

gerritbot added a project: Patch-For-Review.Aug 3 2021, 5:49 PM

Change 709782 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/extensions/GrowthExperiments@master] Update method calls when using UserSelectQueryBuilder

https://gerrit.wikimedia.org/r/709782

Change 709779 merged by jenkins-bot:

[mediawiki/core@master] Rename where* methods in UserSelectQueryBuilder

https://gerrit.wikimedia.org/r/709779

Change 709782 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Update method calls when using UserSelectQueryBuilder

https://gerrit.wikimedia.org/r/709782

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 5 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2021, 12:10 AM

tchin moved this task from UserStore pile to On the train on the Platform Team Workboards (MW Expedition) board.Aug 5 2021, 4:06 PM

tchin closed this task as Resolved.Aug 11 2021, 3:26 PM