BaseTemplate::getFooterIcons was deprecated in 1.35 and will omit warnings in 1.36 (T267447). The method was replaced with a method on the Skin in a move towards making classes that extend BaseTemplates logic-less and only concerned with the render of data.
Practically this means:
- If you are calling $this->getFooterIcons() without arguments, make use of $this->get('footericons').
- Skins that are using icononly or nocopyright parameters will need to make modifications to the return value of $this->get('footericons') like so:
with copyright parameter:
$footericons = $this->get('footericons');
unset( $footericons['copyright'] );with icononly parameter
$footericons = $this->get('footericons');
foreach ( $footericons as $footerIconsKey => &$footerIconsBlock ) {
foreach ( $footerIconsBlock as $footerIconKey => $footerIcon ) {
if ( !isset( $footerIcon['src'] ) ) {
unset( $footerIconsBlock[$footerIconKey] );
}
}
}SkinTemplate::getFooterIcons()` outside the template.
Impacted skins are tagged accordingly in case these skins want to ensure they do not omit warnings in the 1.36 release:
https://codesearch.wmcloud.org/search/?q=getFooterIcons&i=nope&files=&excludeFiles=&repos=
TODO
- Fix skins
- Remove the code