It will bring down the whole wiki. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/672570/8/backend/FlaggedRevs.php@88
We need to change the merge strategy.
It will bring down the whole wiki. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/672570/8/backend/FlaggedRevs.php@88
We need to change the merge strategy.
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/FlaggedRevs | master | +4 -2 | Make merge_strategy of dimensions to be replace |
Change 674485 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/FlaggedRevs@master] Make merge_strategy of dimensions to be replace
I couldn't reproduce it locally so it's very likely won't break anything but better safe than sorry. ^
I'm sure this won't affect production as we rewrite global variables with extension functions, not localsettings but needs fixing regardless. The above patch wouldn't fix it ^
The underling problem here is the fact that extension registry doesn't handle complex array configs (as it shouldn't) one way to move forward here is to replace those arrays with one or two config variables once we dropped the quality tier.
Change 674485 abandoned by Ladsgroup:
[mediawiki/extensions/FlaggedRevs@master] Make merge_strategy of dimensions to be replace
Reason:
The whole config should just be replaced.