Flagged revs will break if the dimension is set to something other than "accuracy" (except on Wikimedia production)
Open, Needs TriagePublic
Actions

Description

It will bring down the whole wiki. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/672570/8/backend/FlaggedRevs.php@88

We need to change the merge strategy.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/FlaggedRevs	master	+4 -2	Make merge_strategy of dimensions to be replace

Customize query in gerrit

Event Timeline

Ladsgroup triaged this task as Unbreak Now! priority.Mar 24 2021, 6:59 AM

Ladsgroup created this task.

RhinosF1 added a project: MediaWiki-extensions-FlaggedRevs.Mar 24 2021, 7:03 AM

Change 674485 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/FlaggedRevs@master] Make merge_strategy of dimensions to be replace

https://gerrit.wikimedia.org/r/674485

gerritbot added a project: Patch-For-Review.Mar 24 2021, 7:11 AM

I couldn't reproduce it locally so it's very likely won't break anything but better safe than sorry. ^

Majavah added a subscriber: Majavah.Mar 24 2021, 7:13 AM

I'm sure this won't affect production as we rewrite global variables with extension functions, not localsettings but needs fixing regardless. The above patch wouldn't fix it ^

Ladsgroup removed a parent task: T274940: 1.36.0-wmf.36 deployment blockers.Mar 24 2021, 7:29 AM

Peachey88 added a subscriber: Peachey88.Mar 24 2021, 10:19 AM

Jdforrester-WMF renamed this task from Flagged revs will break if the dimension is set to something other than "accuracy" to Flagged revs will break if the dimension is set to something other than "accuracy" (except on Wikimedia production).Mar 27 2021, 1:08 AM

Jdforrester-WMF changed the subtype of this task from "Production Error" to "Task".

Jdforrester-WMF updated the task description. (Show Details)

The underling problem here is the fact that extension registry doesn't handle complex array configs (as it shouldn't) one way to move forward here is to replace those arrays with one or two config variables once we dropped the quality tier.

Change 674485 abandoned by Ladsgroup:
[mediawiki/extensions/FlaggedRevs@master] Make merge_strategy of dimensions to be replace

Reason:
The whole config should just be replaced.

https://gerrit.wikimedia.org/r/674485

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2021, 8:10 AM

thcipriani edited projects, added Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)); removed Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)).Tue, Apr 20, 12:37 AM

thcipriani edited projects, added Release-Engineering-Team (Doing); removed Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Tue, Apr 20, 4:25 AM

thcipriani edited projects, added Release-Engineering-Team (Radar); removed Release-Engineering-Team (Doing).Tue, Apr 20, 4:46 PM

thcipriani moved this task from Limbo to Watching/External on the Release-Engineering-Team (Radar) board.