MergeHistory: Avoid querying master DB for the purpose of trivial message variation
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ammarpad
	Mar 24 2021, 9:53 AM

Description

SpecialMergeHistory uses Title::exists( Title::READ_LATEST ) (which may query master) to decide whether to append additional explanatory message to the output. However, MergeHistory authoritatively knows whether the page is deleted or not and if it passes this fact to the special page, then the special page would have no need to make that query (which can even be unreliable after all due to T265775)

Details

	Subject	Repo	Branch	Lines +/-
	MergeHistory: Avoid potential DB query for trivial message variation	mediawiki/core	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned Here: T265775: Retire TitleExists hook

Event Timeline

Ammarpad created this task.Mar 24 2021, 9:53 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 9:53 AM

Ammarpad renamed this task from MergeHistory should query master for the purpose of trivial message variation to MergeHistory: Avoid querying master DB for the purpose of trivial message variation.Mar 24 2021, 9:56 AM

Change 674520 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] MergeHistory: Avoid potential DB query for trivial message variation

https://gerrit.wikimedia.org/r/674520

gerritbot added a project: Patch-For-Review.Mar 24 2021, 9:59 AM

Change 674520 merged by jenkins-bot:

[mediawiki/core@master] MergeHistory: Avoid potential DB query for trivial message variation

https://gerrit.wikimedia.org/r/674520

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 8 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2021, 6:10 PM

Jdforrester-WMF closed this task as Resolved.Jun 8 2021, 6:48 PM

Jdforrester-WMF assigned this task to Ammarpad.