Page MenuHomePhabricator

Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters
Closed, ResolvedPublic

Description

There are times when an editor wants their signature to appear other than at the very end of the comment (e.g. here, where it was inside <small> markup) but discussion tools recognises a comment as having been signed only if exactly four tildes are the last non-whitespace characters in the input box. This includes wikimarkup for, e.g. italic, in source mode.

Steps to reproduce:

  1. On any discussion page with discussion tools enabled, reply to a comment or start a new discussion.
  2. In source mode enter any text, followed by four tildes, and then one or more non-whitespace characters, e.g. ''Italic ~~~~''
  3. View the preview and/or save the comment

Expected results:

  • Italic Thryduulf (talk) 17:00 24 March 2021 (UTC)

Actual results

  • Italic Thryduulf (talk) 17:00 24 March 2021 (UTC) Thryduulf (talk) 17:00 24 March 2021 (UTC)

Event Timeline

This ticket is clear and easy to understand – we appreciate you filing it, @Thryduulf.

The Editing Team is going to look at this task, along with other signature-related tickets, in the next quarter (read: within a month or so):

matmarex renamed this task from Discussion tools doesn't detect a manually-added siganture when followed by any non-whitespace characters to Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters.Apr 7 2021, 7:33 PM

Change 759841 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Improve detecting already signed comments

https://gerrit.wikimedia.org/r/759841

Change 759841 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Improve detecting already signed comments

https://gerrit.wikimedia.org/r/759841

As expected Discussion tools detect a manually-added signature when followed by any non-whitespace characters

Screenshot 2022-03-08 at 17.00.54.png (782×1 px, 140 KB)

Screenshot 2022-03-08 at 16.51.43.png (842×1 px, 161 KB)

As opposed to:
Screenshot 2022-03-08 at 17.00.31.png (1×1 px, 180 KB)

Screenshot 2022-03-08 at 16.50.01.png (1×1 px, 167 KB)