Page MenuHomePhabricator

Production of New Annual Fund Thank You Email (due to ED transition)
Closed, ResolvedPublic

Description

Hello!

I pushed to Gerritt https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/674649 the edits to the following 17 languages (both HTML file and corresponding Subject line file) :
ca
da
de
es-mx
es
fr-ca
fr
he
hu
it
lv
mk
nb
nl
pt-BR
pt
sk
zh

Note that two subject line files: thank_you.zh.subject and thank_you.fr-ca.subject were not pre-existing before, so they were added as new files. They are the corresponding subject line files for the respective HTML files thank_you.zh.html and thank_you.fr-ca.html

@Cstone also put on staging the remaining 8 languages ( see https://phabricator.wikimedia.org/T277779) :
English
Japanese
Polish
Russian
Romanian
Swedish
Ukrainian
Chinese

Please let me know if you need any additional info from me to get the 17 languages on staging as well.

Thank you!
Camille

Related Objects

Event Timeline

Super speedy. Thank you Christine! I'll follow up on this phab task if any need edits and/or when they are ready for push to production.

Hi all following up on this phab task. Pending the address change within the Chinese Thank You email footer (see https://phabricator.wikimedia.org/T277779) , please feel free to push these emails to production, per Thea's email in the thread SL "[Important] New TY email logistics & timing" .

I will do any final proofing via the Production Testmeister instead of the Staging Testmeister. TY!

I also updated the from name to be Jimmy Wales

DStrine triaged this task as High priority.Mar 31 2021, 4:06 PM

Thank you Christine!

I organized proofing of a few languages. Here are a few edits for French and Italian:

  • French: "suivez instructions" should "suivez ces instructions"
  • Italian: edits are made in suggestion mode in the google doc

One edit to the English version:

There's a typo in the first phrase, it should be "for your recurring gift of (amount) in support of Wikipedia." and not "your recurring gift of (amount) you made in support..." (I only saw it because the repetition of "your gift" and "you made" seemed unnatural to me so I went to check the google doc)

Change 676681 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/crm@master] Update 2021 thank you emails.

https://gerrit.wikimedia.org/r/676681

Quick Update: Japanese, Hebrew, Swedish, and Spanish-LATAM are currently being reviewed (WIP). Once those are reviewed and updated (along with English, French, and Italian) we can resolve this phab ticket, as our upcoming Q4, Q1, and Q2 campaigns will be covered. The remaining languages we will do the final proof on a rolling basis pre-campaign (as we have in the past) to account for any potential change in copy after Q2 due to new ED.

Edit to fr-CA :

  • First sentence of monthly : "Je suis heureux d'être celui à qui revient le privilège de vous remercier pour la contribution mensuelle de € 1.99 que vous faites en faveur à Wikipédia." --->>> It should be "..en faveur de Wikipédia..".
  • The link for "programme de dons jumelés" leads to the page in English, we do have here the French version

Edit to Hebrew:

Edits to Japanese:

Edits to es-MX

Edit to sv-SE

  • The first sentence of the one-time donation version needs to be changed to: "Det är med stor glädje jag tackar dig för din engångsgåva på (amount) till stöd för Wikipedia."

Still Pending Final Review :

  • Swedish

Both Tomasz and I are getting an error message when attempting to send ourselves the MK thank you email via Production Testmeister :

Twig\Error\SyntaxError: Unexpected end of template. in Twig\TokenStream->next() (line 64 of /srv/org.wikimedia.civicrm/drupal/sites/all/modules/thank_you/templates/html/thank_you.mk.html).

@CDenes_WMF that's what happens when one of the if / else statements is missing a closing tag or maybe has a typo. I'll see what is causing it and update it.

Change 677672 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/crm@master] Add back in missing endif

https://gerrit.wikimedia.org/r/677672

Change 677672 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add back in missing endif

https://gerrit.wikimedia.org/r/677672

@CDenes_WMF the MK thank you email can be sent now

@LeanneS I updated the checkbox email template to match the new English TY

Thank you @Cstone ! And please let me know if you need any additional info for the corrections to en, fr, it, frCA, he, ja, esMX, and sv

Change 676681 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update 2021 thank you emails.

https://gerrit.wikimedia.org/r/676681

@CDenes_WMF the edits are now live on production

Awesome, thank you Christine! Those were the time sensitive batch :)

I have a second batch of languages that are less time sensitive than the first. Here they are (all edits can be found in yellow highlight in their respective google doc linked) :

Then there will be a third (and hopefully final) batch of the last 7 languages that are out for final proof (also not as time sensitive). Hope that may help with time mgmt. Thanks again for all the speedy support.

  • Camille

Hi @DStrine ! Not resolved just quite yet. Second batch needs to be put in production (per my comment on Apr 14). And third and final batch details coming soon. Thank you!

Change 683450 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/crm@master] Update 2021 thank you email.

https://gerrit.wikimedia.org/r/683450

Change 683450 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update 2021 thank you emails

https://gerrit.wikimedia.org/r/683450

Hi @Cstone ! Third and Final batch of proofing has been complete. Here are the last languages that need edits. Edits can be found in linked google doc in yellow highlight:

Thank you so much. And that is the final batch of edits :)
Camille

Change 688374 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/crm@master] Update ty email for 2021

https://gerrit.wikimedia.org/r/688374

Change 688374 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update ty email for 2021

https://gerrit.wikimedia.org/r/688374

@CDenes_WMF the last changes have been deployed