Page MenuHomePhabricator

Create the ResourceLoaderSkinModule `interface-category` feature
Closed, ResolvedPublic

Description

The legacy feature includes styling for categories at the bottom of skins. Some skins, notably Minerva do not use these. Other skins, understandably want to use these.

Since categories relate to interface, a new "interface-category" feature is proposed.

  • An import statement is added to legacy code to import category styles from a separate file "interface-category.less"
  • A new interface-category feature is added to ResourceLoaderSkinModule that imports this file without the rest of legacy.
  • Fix the documentation of ResourceLoaderSkinModule. The feature is named interface-category not category-interface.

Developer notes

the new feature should include the following styles:

#catlinks {
	/**
	 * Overrides text justification (user preference)
	 * See T33990
	 */
	text-align: left;
}

.catlinks ul {
	display: inline;
	margin: 0;
	padding: 0;
	list-style: none none;
}

.catlinks li {
	display: inline-block;
	line-height: 1.25em;
	border-left: 1px solid #a2a9b1;
	margin: 0.125em 0;
	padding: 0 0.5em;
}

.catlinks li:first-child {
	padding-left: 0.25em;
	border-left: 0;
}

/* (T7346) make category redirects italic */
.catlinks li a.mw-redirect {
	font-style: italic;
}

/**
 * Hidden categories
 */
.mw-hidden-cats-hidden {
	display: none;
}

.catlinks-allhidden {
	display: none;
}

Event Timeline

Change 674809 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/core@master] split legacy category styles into interface-category feature

https://gerrit.wikimedia.org/r/674809

Mainframe98 renamed this task from Create the ResourceLoaderSkinModule `category-interface` feature to Create the ResourceLoaderSkinModule `interface-category` feature.Mar 25 2021, 8:44 AM
Mainframe98 claimed this task.
Mainframe98 added a subscriber: Mainframe98.

Change 674809 merged by jenkins-bot:
[mediawiki/core@master] split legacy category styles into interface-category feature

https://gerrit.wikimedia.org/r/674809

Change 674837 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Revert "split legacy category styles into interface-category feature"

https://gerrit.wikimedia.org/r/674837

Change 674837 abandoned by Jdlrobson:
[mediawiki/core@master] Revert "split legacy category styles into interface-category feature"

Reason:
Only the documentation is wrong not the feature name so no need to revert.

https://gerrit.wikimedia.org/r/674837

Change 675581 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/core@master] Resourceloader: Correct documentation of skin module

https://gerrit.wikimedia.org/r/675581

Change 675581 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoader: Correct documentation of skin module

https://gerrit.wikimedia.org/r/675581

Jdlrobson updated the task description. (Show Details)