| Jdlrobson | |
| Mar 24 2021, 7:20 PM |
| F34191108: Screen Shot 2021-03-25 at 4.48.06 PM.png | |
| Mar 25 2021, 11:50 PM |
| F34191097: Screen Shot 2021-03-25 at 4.31.03 PM.png | |
| Mar 25 2021, 11:37 PM |
| F34191100: Screen Shot 2021-03-25 at 4.36.05 PM.png | |
| Mar 25 2021, 11:37 PM |
The legacy feature inside ResourceLoaderSkinModule refers to a mw-datatable class which is only used inside the TablePager PHP class which already has a dedicated stylesheet. We should move them.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | dancy | T281161 1.37.0-wmf.20 deployment blockers | ||
| Resolved | Jdlrobson | T89981 Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature | |||
| Resolved | Mainframe98 | T278374 Move the `mw-datatable` rules out of legacy to mediawiki.pager.tablePager |
I'm also seeing this in other places than TablePager, such as Special:Tags and Special:TrackingCategories, which do not use TablePager.
Certain extensions, such as MediaWiki-extensions-Cargo, MediaWiki-extensions-SecurePoll and CheckUser use this outside TablePager too. They'll need converting before this can be split out without regressions.
@Mainframe98 what kind of damage are we looking at if those styles were to disappear from legacy? Is it acceptable?
SecurePoll, CheckUser, Cargo can add the mediawiki.pager.tablePager module to their pages before we make the move if it's not.
Regression kind of stuff, as it removes all the styles from those tables. At least for the core special pages, that's trainblocker stuff.
Depending on how you'd like to prioritize it, adding mediawiki.pager.tablePager as a workaround would work, and related code can be converted to use TablePager afterwards.
For the extensions I'm not sure. CheckUser only uses it in JS, Cargo has partial styling for that table and SecurePoll is unknown territory for me.
I also found a few outdated gadgets using it: https://global-search.toolforge.org/?q=mw-datatable®ex=1&namespaces=8&title=, most of which copy an old version of https://commons.wikimedia.org/wiki/MediaWiki:Gadget-Cat-a-lot.js.
Right, perhaps the best approach here then is
Sounds like a plan!
I took a stab at converting Special:Tags and Special:TrackingCategories to use TablePager, but that's quite complex, due their data structures being unsuitable for use in TablePager.
Change 674953 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/core@master] Move mw-datatables styles to mediawiki.pager.tablePager
Change 674954 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/extensions/Cargo@master] Use mediawiki.pager.tablePager on Special:CargoTables
Change 674955 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/extensions/CheckUser@master] Add mediawiki.pager.tablePager as dependency of ext.CheckUser
Change 674954 merged by jenkins-bot:
[mediawiki/extensions/Cargo@master] Use mediawiki.pager.tablePager on Special:CargoTables
Change 674953 merged by jenkins-bot:
[mediawiki/core@master] Move mw-datatables styles to mediawiki.pager.tablePager
Good news! SecurePoll already uses TablePager so it includes the mediawiki.pager.tablePager module so we're done here. Attached is a screenshot showing this is working as expected when Vector disables the legacy module.
Change 674955 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add mediawiki.pager.tablePager as dependency of ext.CheckUser
(Mind you, I don't endorse that use, but this is another example where due diligence was missed.)
The change we made here should be backwards compatible (for now) [1]
We will deal with template usages at a later date when we actually remove the styles from skins.
