Page MenuHomePhabricator
Create Task
Maniphest T278375

Class 'GlobalUsageHooks' not found
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.36

message
Class 'GlobalUsageHooks' not found

Impact

Notes

A few occurrences immediately after 1.36.0-wmf.36. Seems to be caused by the onPageMoveComplete.

Details

Request URL
https://commons.wikimedia.org/w/api.php
Stack Trace
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.36/includes/HookContainer/HookContainer.php(330)
#0 /srv/mediawiki/php-1.36.0-wmf.36/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#1 /srv/mediawiki/php-1.36.0-wmf.36/includes/HookContainer/HookRunner.php(2874): MediaWiki\HookContainer\HookContainer->run(string, array)
#2 /srv/mediawiki/php-1.36.0-wmf.36/includes/MovePage.php(829): MediaWiki\HookContainer\HookRunner->onPageMoveComplete(Title, Title, User, integer, integer, string, MediaWiki\Revision\RevisionStoreRecord)
#3 /srv/mediawiki/php-1.36.0-wmf.36/includes/libs/rdbms/database/Database.php(4516): MovePage->{closure}(Wikimedia\Rdbms\DatabaseMysqli, string)
#4 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/AtomicSectionUpdate.php(39): Wikimedia\Rdbms\Database->doAtomicSection(string, Closure)
#5 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/DeferredUpdates.php(513): AtomicSectionUpdate->doUpdate()
#6 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/DeferredUpdates.php(390): DeferredUpdates::attemptUpdate(AtomicSectionUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#7 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(AtomicSectionUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#8 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(AtomicSectionUpdate, integer)
#9 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#10 /srv/mediawiki/php-1.36.0-wmf.36/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#11 /srv/mediawiki/php-1.36.0-wmf.36/includes/MediaWiki.php(1097): DeferredUpdates::doUpdates(string)
#12 /srv/mediawiki/php-1.36.0-wmf.36/includes/MediaWiki.php(834): MediaWiki->restInPeace()
#13 /srv/mediawiki/php-1.36.0-wmf.36/includes/MediaWiki.php(846): MediaWiki->{closure}()
#14 /srv/mediawiki/php-1.36.0-wmf.36/api.php(125): MediaWiki->doPostOutputShutdown()
#15 /srv/mediawiki/php-1.36.0-wmf.36/api.php(45): wfApiMain()
#16 /srv/mediawiki/w/api.php(3): require(string)
#17 {main}
SubjectRepoBranchLines +/-
Fix hook registration after class was namespacedmediawiki/extensions/GlobalUsagewmf/1.36.0-wmf.36+3 -35
Fix "Class 'GlobalUsageHooks' not found"mediawiki/extensions/GlobalUsagemaster+2 -2
Fix hook registration after class was namespacedmediawiki/extensions/GlobalUsagemaster+3 -35
Follow-up 1bb7ba1: Fix stray reference to removed Hooks classmediawiki/extensions/GlobalUsagemaster+2 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasehasharT274940 1.36.0-wmf.36 deployment blockers
 ResolvedPRODUCTION ERRORLegoktmT278375 Class 'GlobalUsageHooks' not found

Event Timeline

hashar triaged this task as Unbreak Now! priority.Mar 24 2021, 7:21 PM
hashar created this task.
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMar 24 2021, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
hashar added a parent task: T274940: 1.36.0-wmf.36 deployment blockers.Mar 24 2021, 7:21 PM
Jdforrester-WMF subscribed.Mar 24 2021, 7:23 PM

Oop.s

gerritbot added a comment.Mar 24 2021, 7:25 PM

Change 674664 had a related patch set uploaded (by Legoktm; author: Legoktm):
[mediawiki/extensions/GlobalUsage@master] Fix hook registration after class was namespaced

https://gerrit.wikimedia.org/r/674664

gerritbot added a project: Patch-For-Review.Mar 24 2021, 7:25 PM

Change 674666 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/GlobalUsage@master] Fix "Class 'GlobalUsageHooks' not found"

https://gerrit.wikimedia.org/r/674666

gerritbot added a comment.Mar 24 2021, 7:26 PM

Change 674665 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/GlobalUsage@master] Follow-up 1bb7ba1: Fix stray reference to removed Hooks class

https://gerrit.wikimedia.org/r/674665

gerritbot added a comment.Mar 24 2021, 7:37 PM

Change 674665 abandoned by Jforrester:
[mediawiki/extensions/GlobalUsage@master] Follow-up 1bb7ba1: Fix stray reference to removed Hooks class

Reason:
Lego's one does both together.

https://gerrit.wikimedia.org/r/674665

hashar mentioned this in T274940: 1.36.0-wmf.36 deployment blockers.Mar 24 2021, 7:46 PM
gerritbot added a comment.Mar 24 2021, 7:49 PM

Change 674664 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@master] Fix hook registration after class was namespaced

https://gerrit.wikimedia.org/r/674664

gerritbot added a comment.Mar 24 2021, 7:55 PM

Change 674666 abandoned by DannyS712:
[mediawiki/extensions/GlobalUsage@master] Fix "Class 'GlobalUsageHooks' not found"

Reason:
done by Legoktm at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalUsage/ /674664

https://gerrit.wikimedia.org/r/674666

gerritbot added a comment.Mar 24 2021, 7:57 PM

Change 674670 had a related patch set uploaded (by Jforrester; author: Legoktm):
[mediawiki/extensions/GlobalUsage@wmf/1.36.0-wmf.36] Fix hook registration after class was namespaced

https://gerrit.wikimedia.org/r/674670

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 24 2021, 8:00 PM
gerritbot added a comment.Mar 24 2021, 8:57 PM

Change 674670 merged by jenkins-bot:
[mediawiki/extensions/GlobalUsage@wmf/1.36.0-wmf.36] Fix hook registration after class was namespaced

https://gerrit.wikimedia.org/r/674670

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 24 2021, 9:00 PM
Stashbot added a comment.Mar 24 2021, 9:02 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-24T21:02:52Z] <hashar@deploy1002> Synchronized php-1.36.0-wmf.36/extensions/GlobalUsage: Fix hook registration after class was namespaced - T278375 (duration: 01m 07s)

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2021, 9:10 PM
hashar closed this task as Resolved.Mar 24 2021, 9:16 PM
hashar assigned this task to Legoktm.

The patch has been rolled and I have pushed 1.36.0-wmf.36 to group 1. The issue appears to have been resolved.

Thank you for the quick response!

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.May 9 2022, 5:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits