Page MenuHomePhabricator
Create Task
Maniphest T278379

Argument 1 passed to ProofreadPage\Index\IndexTemplateStyles::__construct() must be an instance of Title, null given, called in /srv/mediawiki/php-1.36.0-wmf.36/extensions/ProofreadPage/includes/Page/PageContent.php on line 284
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.36

message
Argument 1 passed to ProofreadPage\Index\IndexTemplateStyles::__construct() must be an instance of Title, null given, called in /srv/mediawiki/php-1.36.0-wmf.36/extensions/ProofreadPage/includes/Page/PageContent.php on line 284

Impact

Apparently prevent submitting content on wikisources wikis due to ProofreadPage extension.

Notes

Probably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/672760 : Add default TemplateStyles for an Index

Details

Request URL
https://en.wikisource.org/w/api.php
Stack Trace
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.36/extensions/ProofreadPage/includes/Index/IndexTemplateStyles.php(21)
#0 /srv/mediawiki/php-1.36.0-wmf.36/extensions/ProofreadPage/includes/Page/PageContent.php(284): ProofreadPage\Index\IndexTemplateStyles->__construct(NULL)
#1 /srv/mediawiki/php-1.36.0-wmf.36/includes/content/ContentHandler.php(908): ProofreadPage\Page\PageContent->getParserOutput(Title, NULL, ParserOptions, boolean)
#2 /srv/mediawiki/php-1.36.0-wmf.36/includes/content/ContentHandler.php(947): ContentHandler->getChangeType(ProofreadPage\Page\PageContent, ProofreadPage\Page\PageContent, integer)
#3 /srv/mediawiki/php-1.36.0-wmf.36/extensions/ProofreadPage/includes/Page/PageContentHandler.php(343): ContentHandler->getAutosummary(ProofreadPage\Page\PageContent, ProofreadPage\Page\PageContent, integer)
#4 /srv/mediawiki/php-1.36.0-wmf.36/includes/Storage/PageUpdater.php(651): ProofreadPage\Page\PageContentHandler->getAutosummary(ProofreadPage\Page\PageContent, ProofreadPage\Page\PageContent, integer)
#5 /srv/mediawiki/php-1.36.0-wmf.36/includes/Storage/PageUpdater.php(809): MediaWiki\Storage\PageUpdater->makeAutoSummary(integer)
#6 /srv/mediawiki/php-1.36.0-wmf.36/includes/page/WikiPage.php(2217): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#7 /srv/mediawiki/php-1.36.0-wmf.36/includes/page/WikiPage.php(2071): WikiPage->doUserEditContent(ProofreadPage\Page\PageContent, User, CommentStoreComment, integer, boolean, array, integer)
#8 /srv/mediawiki/php-1.36.0-wmf.36/includes/EditPage.php(2357): WikiPage->doEditContent(ProofreadPage\Page\PageContent, string, integer, boolean, User, string, array, integer)
#9 /srv/mediawiki/php-1.36.0-wmf.36/includes/EditPage.php(1690): EditPage->internalAttemptSave(array, boolean)
#10 /srv/mediawiki/php-1.36.0-wmf.36/includes/api/ApiEditPage.php(454): EditPage->attemptSave(array)
#11 /srv/mediawiki/php-1.36.0-wmf.36/includes/api/ApiMain.php(1647): ApiEditPage->execute()
#12 /srv/mediawiki/php-1.36.0-wmf.36/includes/api/ApiMain.php(617): ApiMain->executeAction()
#13 /srv/mediawiki/php-1.36.0-wmf.36/includes/api/ApiMain.php(588): ApiMain->executeActionWithErrorHandling()
#14 /srv/mediawiki/php-1.36.0-wmf.36/api.php(90): ApiMain->execute()
#15 /srv/mediawiki/php-1.36.0-wmf.36/api.php(45): wfApiMain()
#16 /srv/mediawiki/w/api.php(3): require(string)
#17 {main}
ProjectBranchLines +/-Subject
mediawiki/extensions/ProofreadPagemaster+7 -154Revert "Add default TemplateStyles for an Index"
mediawiki/extensions/ProofreadPagewmf/1.36.0-wmf.36+7 -154Revert "Add default TemplateStyles for an Index"
mediawiki/extensions/ProofreadPagemaster+6 -5Fixes a NPE on Page: pages parsing when there is no Index: page
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar triaged this task as Unbreak Now! priority.Mar 24 2021, 7:29 PM
hashar created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 7:29 PM
hashar added a parent task: T274940: 1.36.0-wmf.36 deployment blockers.Mar 24 2021, 7:29 PM
gerritbot added a comment.Mar 24 2021, 7:41 PM

Change 674691 had a related patch set uploaded (by Tpt; author: Tpt):
[mediawiki/extensions/ProofreadPage@master] Fixes a NPE on Page: pages parsing when there is no Index: page

https://gerrit.wikimedia.org/r/674691

gerritbot added a project: Patch-For-Review.Mar 24 2021, 7:42 PM
hashar mentioned this in T274940: 1.36.0-wmf.36 deployment blockers.Mar 24 2021, 7:46 PM
gerritbot added a comment.Mar 24 2021, 7:55 PM

Change 674691 abandoned by Tpt:
[mediawiki/extensions/ProofreadPage@master] Fixes a NPE on Page: pages parsing when there is no Index: page

Reason:
a rollback is better

https://gerrit.wikimedia.org/r/674691

hashar assigned this task to Tpt.Mar 24 2021, 7:56 PM

@Tpt proposed a fix already unfortunately it was not complete. Looks like we will rollback the feature instead and let it some time to be polished.

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2021, 8:10 PM
gerritbot added a comment.Mar 24 2021, 8:44 PM

Change 674669 had a related patch set uploaded (by Tpt; author: Tpt):
[mediawiki/extensions/ProofreadPage@master] Revert "Add default TemplateStyles for an Index"

https://gerrit.wikimedia.org/r/674669

gerritbot added a project: Patch-For-Review.Mar 24 2021, 8:44 PM
gerritbot added a comment.Mar 24 2021, 8:50 PM

Change 674672 had a related patch set uploaded (by Hashar; author: Tpt):
[mediawiki/extensions/ProofreadPage@wmf/1.36.0-wmf.36] Revert "Add default TemplateStyles for an Index"

https://gerrit.wikimedia.org/r/674672

gerritbot added a comment.Mar 24 2021, 8:56 PM

Change 674672 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@wmf/1.36.0-wmf.36] Revert "Add default TemplateStyles for an Index"

https://gerrit.wikimedia.org/r/674672

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 24 2021, 9:00 PM
gerritbot added a comment.Mar 24 2021, 9:04 PM

Change 674669 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Revert "Add default TemplateStyles for an Index"

https://gerrit.wikimedia.org/r/674669

Stashbot added a comment.Mar 24 2021, 9:05 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-24T21:05:20Z] <hashar@deploy1002> Synchronized php-1.36.0-wmf.36/extensions/ProofreadPage: Revert "Add default TemplateStyles for an Index" - T278379 (duration: 01m 07s)

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2021, 9:10 PM
hashar closed this task as Resolved.Mar 24 2021, 9:17 PM

The patch has been rolled back and I have pushed 1.36.0-wmf.36 to group 1. The issue is thus resolved.

Sorry @Inductiveload & @Tpt! Doesn't mean the feature is unwanted, but merely that the patch needs a little bit more work.

Resolving since that was solely to track the error surfacing on Wikimedia cluster.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 24 2021, 10:00 PM
Tpt mentioned this in T215165: Allow an individual CSS page for any book.Mar 25 2021, 12:33 PM
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Apr 21 2022, 8:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL