Page MenuHomePhabricator
Create Task
Maniphest T278381

Wikipedia Preview debug mode
Closed, ResolvedPublic
Actions

Description

Value statement

As a Wikipedia Preview partner
I want to know what Wikipedia Preview is trying to do
So I can figure out why it's not working

Request

Introduce a debug boolean option to the init() function. When set to true or something truthy, the component will output all relevant information to the js console

  • Which content section it is trying to find preview targets in
  • How it is trying to find preview targets (selector vs hyperlinks)
  • For each preview targets found
    • text
    • title
    • lang
  • Anything else that looks relevant for debugging purposes

Update the documentation in the README accordingly

Event Timeline

SBisson created this task.Mar 24 2021, 7:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 7:33 PM
SBisson moved this task from Backlog to Q4 FY2020-21 on the Inuka-Team board.Mar 24 2021, 7:33 PM
SBisson triaged this task as Medium priority.Mar 25 2021, 12:52 PM
SBisson moved this task from Q4 FY2020-21 to Kanban on the Inuka-Team board.
SBisson edited projects, added Inuka-Team (Kanban); removed Inuka-Team.
SBisson updated the task description. (Show Details)
• Rileych moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Mar 25 2021, 2:20 PM
hueitan claimed this task.Apr 7 2021, 9:38 AM
hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
hueitan updated the task description. (Show Details)Apr 7 2021, 1:34 PM
hueitan updated the task description. (Show Details)Apr 15 2021, 7:17 PM
hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.EditedApr 15 2021, 7:31 PM

PR : https://github.com/wikimedia/wikipedia-preview/pull/108

Screenshot Example : (2nd version, may change later)

image.png (241×1 px, 43 KB)

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Apr 16 2021, 1:38 PM
• Jpita moved this task from QA to QA WAITING FOR FEEDBACK on the Inuka-Team (Kanban) board.Apr 20 2021, 6:39 PM
• Jpita subscribed.

I see 3 wikipedia links found in the console but the article only has 2 links.
Is this expected?
The last link found seems to be in the footer but it is not a preview enabled word.

image.png (1×2 px, 546 KB)

hueitan moved this task from QA WAITING FOR FEEDBACK to QA on the Inuka-Team (Kanban) board.EditedApr 21 2021, 9:07 AM
In T278381#7021851, @Jpita wrote:

I see 3 wikipedia links found in the console but the article only has 2 links.
Is this expected?
The last link found seems to be in the footer but it is not a preview enabled word.

You are right and this doesn't matter, this is just the example, if you pass the root in the function, then you can have the scope, otherwise it grabs everything on the page.

• Jpita moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Apr 21 2021, 11:36 AM
• AMuigai moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Apr 28 2021, 2:07 PM
• AMuigai closed this task as Resolved.May 4 2021, 6:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits