Table styles should be pulled out of legacy into their own feature
Closed, ResolvedPublic
Actions

Description

The legacy feature includes styling for tables. Some skins, notably Minerva do not use these. Other skins, understandably want to use these. Having these in a single place will also allow us to consider how they behave on lower resolutions.

a new "content-tables" feature is proposed.

An import statement is added to legacy code to import the wikitable styles from a separate file "content.tables.less"
A new content.tables feature is added to ResourceLoaderSkinModule that imports this file without the rest of legacy.

Developer notes

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	dancy	T281161 1.37.0-wmf.20 deployment blockers
Resolved		Jdlrobson	T89981 Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts and deprecate use of the feature
Resolved		Mainframe98	T278401 Table styles should be pulled out of legacy into their own feature

Event Timeline

Jdlrobson triaged this task as High priority.Mar 25 2021, 12:05 AM

Jdlrobson created this task.

Jdlrobson removed projects: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).

Jdlrobson moved this task from Backlog to Phase 4 - Standardize ResourceLoaderSkinModules styling rules on the MediaWiki-Core-Skin-Architecture board.

Change 674821 had a related patch set uploaded (by Mainframe98; author: Mainframe98):
[mediawiki/core@master] Create a content-tables feature split from legacy

https://gerrit.wikimedia.org/r/674821

gerritbot added a project: Patch-For-Review.Mar 25 2021, 9:50 AM

Mainframe98 claimed this task.Mar 25 2021, 9:50 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 25 2021, 11:00 PM