When Cargo query is run on a page TOC disappears
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reception123
	Mar 25 2021, 6:14 AM

Description

Steps to reproduce:

Create a page with the minimum amount necessary to automatically render the TOC
Query a table (before the first heading)
- TOC does not render. If you inspect the page, is not even just hidden with some CSS setting.

Original bug report: https://phabricator.miraheze.org/T7028

MediaWiki: 1.35.1
PHP: 7.3.27-1~deb10u1 (fpm-fcgi)
MariaDB: 10.4.15-MariaDB-1:10.4.15+maria~buster-log

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Partial revert of 197438ad7fe8 - remove NOTOC from query results	mediawiki/extensions/Cargo	master	+6 -5
	Bring back table of contents on pages with Cargo queries	mediawiki/extensions/Cargo	master	+0 -8

Customize query in gerrit

Related Objects

Mentioned Here: rECRG876d2faf76b2: Add $wgCargoStoreUseTemplateArgsFallback setting
rECRGa44aec345cee: Fix for b68e9128a778 - fix populating of backlinks table

Event Timeline

Reception123 created this task.Mar 25 2021, 6:14 AM

Restricted Application added a project: User-RhinosF1. · View Herald TranscriptMar 25 2021, 6:14 AM

Restricted Application added subscribers: RhinosF1, Universal_Omega, Aklapper. · View Herald Transcript

Universal_Omega moved this task from Radar to Miraheze-Linked on the User-RhinosF1 board.Mar 25 2021, 6:38 AM

Redmin subscribed.Mar 25 2021, 7:59 AM

SuperHamster subscribed.Mar 27 2021, 1:44 AM

Prod subscribed.Apr 22 2021, 6:36 PM

Reception123 updated the task description. (Show Details)May 16 2021, 4:35 PM

Gy199108 subscribed.May 19 2021, 2:27 PM

Caused by this line in CargoUtils::smartParse.

FrozenPlum subscribed.Nov 25 2021, 8:28 AM

Ribbot subscribed.Feb 19 2022, 4:23 AM

There's a duplicate task here (T307735). Their issue may be resolved?

Aklapper merged a task: T307735: Querying a wikitext field on a page causes the TOC to disappear.Jun 25 2022, 1:47 PM

Aklapper added a subscriber: Pcj.

It's not resolved.

Ah, apologies, I didn’t view the original report. I see it happens only when TOC is auto-generated my Mediawiki, and problem disappears when TOC is positioned with TOC or FORCETOC.

Still occurring on:
MediaWiki 1.38.1 (ede16c4)
PHP 7.4.28 (fpm-fcgi)
MariaDB 10.5.16-MariaDB-1:10.5.16+maria~bullseye-log
Cargo: 3.2 (876d2fa)

Change 813632 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Bring back table of contents on pages with Cargo queries

https://gerrit.wikimedia.org/r/813632

gerritbot added a project: Patch-For-Review.Jul 13 2022, 2:05 PM

Change 813324 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/Cargo@master] Partial revert of 197438ad7fe8 - remove NOTOC from query results

https://gerrit.wikimedia.org/r/813324

Change 813324 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Partial revert of 197438ad7fe8 - remove NOTOC from query results

https://gerrit.wikimedia.org/r/813324

Sorry about this problem, and the long delay on fixing it.

Change 813632 abandoned by Yaron Koren:

[mediawiki/extensions/Cargo@master] Bring back table of contents on pages with Cargo queries

Reason:

Removes too much.

https://gerrit.wikimedia.org/r/813632

Maintenance_bot moved this task from Miraheze-Linked to Done on the User-RhinosF1 board.Jul 13 2022, 5:29 PM

Maintenance_bot removed a project: Patch-For-Review.

When Cargo query is run on a page TOC disappearsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

When Cargo query is run on a page TOC disappears
Closed, ResolvedPublic
Actions