Page MenuHomePhabricator

Add a link: wrong annotation updated when accepting/rejecting recommendation
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Accept/reject recommendation 1
  • Click on recommendation 2
  • Accept/reject recommendation 2

Actual Results:
Acceptance state of recommendation 1 is updated.

Expected Results:
Acceptance state of recommendation 2 is updated.

The right recommendation is updated when navigating using the arrows within the link inspector.

Screen recording: https://drive.google.com/file/d/1xEs0X-iIYCwA1AJmqRsGtjDPPa5fKE5G/view?usp=sharing

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

On desktop, I was able to reproduce this issue consistently without going back to the previously decided recommendation by:

  1. Accept/reject recommendation 1
  2. Click on recommendation 2
  3. In browser console, run ve.init.target.getSurface().getModel().getFragment().getAnnotations().get(0)

GeDmRecommendedLinkAnnotation is that of previous annotation. However, when the same recommendation is selected again, the right annotation data model is selected.

So the issue might be that when the annotation is focused manually the annotation data model isn't selected.

mewoph renamed this task from Add a link: wrong annotation updated when accepting/rejecting recommendation (sometimes) to Add a link: wrong annotation updated when accepting/rejecting recommendation.Apr 8 2021, 10:34 PM
mewoph updated the task description. (Show Details)

Change 678107 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: make sure the correct annotation is udpated

https://gerrit.wikimedia.org/r/678107

Change 678107 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: make sure the correct annotation is updated

https://gerrit.wikimedia.org/r/678107

Etonkovidova subscribed.

Works as expected - checked in betalabs.