Page MenuHomePhabricator

Instrumentation: Number of phrases not found in document
Open, MediumPublic

Description

Per T271124: Add a link engineering: deal with word boundaries (\b) being broken in JS, T267329: Add Link engineering: Output format for link recommendation format, and T271604: Add a link: instance_occurrence should be based on plaintext, not wikitext, we're looking for phrases in the VisualEditor document with some guideposts to help us find them. For various reasons, we may not find them. If so, we'll want to include this data in our instrumentation so we understand that e.g. we expected to have 10 recommendations but could only show 7.

Event Timeline

kostajh triaged this task as Medium priority.Apr 14 2021, 12:53 PM

Change 682613 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Log error if expected link text is not found

https://gerrit.wikimedia.org/r/682613

Change 682613 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Log error if expected link text is not found

https://gerrit.wikimedia.org/r/682613

Change 684127 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/684127

Change 690070 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/690070

Change 684127 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/684127

Change 690070 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/690070

Mentioned in SAL (#wikimedia-operations) [2021-05-13T12:40:40Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/GrowthExperiments: Backport: instrumentation patches ([[gerrit:690070|]] [[gerrit:690071|]] [[gerrit:690072|]] [[gerrit:690073|]]) (T278116 T278117 T278114 T278177 T278487 T278112 T278111 T278118) (duration: 01m 09s)