Page MenuHomePhabricator
Create Task
Maniphest T278487

Instrumentation: Number of phrases not found in document
Closed, ResolvedPublic
Actions

Description

Per T271124: Add a link engineering: deal with word boundaries (\b) being broken in JS, T267329: Add Link engineering: Output format for link recommendation format, and T271604: Add a link: instance_occurrence should be based on plaintext, not wikitext, we're looking for phrases in the VisualEditor document with some guideposts to help us find them. For various reasons, we may not find them. If so, we'll want to include this data in our instrumentation so we understand that e.g. we expected to have 10 recommendations but could only show 7.

Details

SubjectRepoBranchLines +/-
AddLink: LinkSuggestionInteraction logger and instrumentationmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+300 -49
AddLink: LinkSuggestionInteraction logger and instrumentationmediawiki/extensions/GrowthExperimentsmaster+300 -49
AddLink: Log error if expected link text is not foundmediawiki/extensions/GrowthExperimentsmaster+15 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Mar 25 2021, 8:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2021, 8:40 PM
kostajh moved this task from Backlog to Post-release backlog on the Add-Link board.Mar 25 2021, 8:41 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 29 2021, 7:02 AM
kostajh moved this task from Post-release backlog to April 19 - April 23 on the Add-Link board.Mar 29 2021, 11:32 AM
kostajh mentioned this in T267695: Add a link in VE: handle span-wrapped entities and annotations when finding link recommendation phrases.Mar 29 2021, 11:36 AM
kostajh moved this task from Ready for Development to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 30 2021, 7:12 AM
kostajh triaged this task as Medium priority.Apr 14 2021, 12:53 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
kostajh mentioned this in T280533: QA the phrase matching approach.Apr 19 2021, 1:54 PM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 20 2021, 9:20 AM
• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:30 PM
kostajh moved this task from April 19 - April 23 to April 26 - April 30 on the Add-Link board.Apr 26 2021, 9:40 AM
kostajh claimed this task.Apr 26 2021, 12:14 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Apr 26 2021, 12:34 PM

Change 682613 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Log error if expected link text is not found

https://gerrit.wikimedia.org/r/682613

gerritbot added a project: Patch-For-Review.Apr 26 2021, 12:34 PM
gerritbot added a comment.Apr 27 2021, 7:24 PM

Change 682613 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Log error if expected link text is not found

https://gerrit.wikimedia.org/r/682613

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 27 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2021, 8:11 PM
kostajh moved this task from April 26 - April 30 to May 3 - May 7 on the Add-Link board.May 3 2021, 2:42 PM
gerritbot added a comment.May 6 2021, 7:03 PM

Change 684127 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/684127

gerritbot added a project: Patch-For-Review.May 6 2021, 7:03 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 6 2021, 7:03 PM
kostajh moved this task from May 3 - May 7 to May 10 - May 14 on the Add-Link board.May 10 2021, 3:47 PM
gerritbot added a comment.May 13 2021, 10:52 AM

Change 690070 had a related patch set uploaded (by Gergő Tisza; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/690070

gerritbot added a comment.May 13 2021, 11:18 AM

Change 684127 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/684127

gerritbot added a comment.May 13 2021, 11:47 AM

Change 690070 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] AddLink: LinkSuggestionInteraction logger and instrumentation

https://gerrit.wikimedia.org/r/690070

Tgr moved this task from May 10 - May 14 to Done / QA on the Add-Link board.May 13 2021, 12:04 PM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot removed a project: Patch-For-Review.May 13 2021, 12:10 PM
Stashbot added a comment.May 13 2021, 12:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-05-13T12:40:40Z] <tgr@deploy1002> Synchronized php-1.37.0-wmf.5/extensions/GrowthExperiments: Backport: instrumentation patches ([[gerrit:690070|]] [[gerrit:690071|]] [[gerrit:690072|]] [[gerrit:690073|]]) (T278116 T278117 T278114 T278177 T278487 T278112 T278111 T278118) (duration: 01m 09s)

Stashbot mentioned this in T278116: Instrumentation: Link inspector.May 13 2021, 12:40 PM
Stashbot mentioned this in T278114: Instrumentation: Suggestions mode.
Stashbot mentioned this in T278117: Instrumentation: Rejection dialog.
Stashbot mentioned this in T278112: Instrumentation: dialog for no suggestions available.
Stashbot mentioned this in T278111: Instrumentation: Onboarding.
Stashbot mentioned this in T278177: Add a link: create new Schema.
Stashbot mentioned this in T278118: Instrumentation: Edit summary.
Etonkovidova closed this task as Resolved.Jul 22 2021, 8:55 PM
Etonkovidova subscribed.

Checked in wmf.14, e.g.

{action: "impression", action_data: "number_phrases_found=2;number_phrases_expected=2", is_mobile: false, newcomer_task_token: "bbae594c3f455900cc8d", page_id: 113854, …}
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL