Page MenuHomePhabricator

Optimize Image Recommendations Tooltips for Small Screens
Closed, ResolvedPublic

Description

Background
During usability testing, tool tips were cut off on smaller screens.

User Story
As an Android app user with a small screen,
I want tooltips optimized for my screen so words aren't cut off

#mediumFeasibility

Event Timeline

This is related to T269448 and can be fixed in a single PR.

The tooltip library fix PR has been merged to master and now the tooltips are good in small screen device (tested on Nexus S emulator).

Screenshot_1617659353.png (800×480 px, 199 KB)
Screenshot_1617659357.png (800×480 px, 189 KB)

Hi @schoenbaechler
You can download the APK from this PR:
https://github.com/wikimedia/apps-android-wikipedia/pull/2133

@cooltey can you slightly optimize the line-height of the tooltips, it’s font_group_3 from the font guidelines.

DesignvsImplementations
add-images-07.png (1×720 px, 499 KB)
Screenshot_20210408-165637.png (2×1 px, 507 KB)

Other than that, this is good to go!

Hi @schoenbaechler
If we adjust the lineHeight of text, the content height of the tooltip will reach the top of the view and will make the arrow being cut off (see below).

Screenshot_1617910740.png (800×480 px, 68 KB)

Would it be possible to change the tooltip style shown below? Thanks.

Screenshot_1617910875.png (800×480 px, 60 KB)