Parsoid: p-wrapping shouldn't try to wrap <aside> tags
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TK-999
	Mar 26 2021, 4:40 PM

Description

The PortableInfobox extension uses an aside element to wrap its infobox content. It seems that <aside> tags don't play well with p-wrapping in Parsoid, so an article containing such an extension tag will end up with empty p-wrappers around the tag.

Per discussion with @ssastry , we should probably make Parsoid aware of <aside> semantics like it was done for <figure> previously, to avoid this behavior.

Details

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.14.0-a2	mediawiki/vendor	master	+98 -27
Don't p-wrap <aside> tags in extension HTML	mediawiki/services/parsoid	main	+9 -1
Don't p-wrap <aside> tags in extension HTML	mediawiki/services/parsoid	master	+9 -1
Don't p-wrap <aside> tags in extension HTML	mediawiki/core	master	+9 -1

Customize query in gerrit

Event Timeline

TK-999 created this task.Mar 26 2021, 4:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2021, 4:40 PM

Change 675177 had a related patch set uploaded (by TK-999; author: TK-999):
[mediawiki/services/parsoid@master] Don't p-wrap <aside> tags in extension HTML

https://gerrit.wikimedia.org/r/675177

gerritbot added a project: Patch-For-Review.Mar 26 2021, 5:28 PM

What's happening is that the doBlockLevels in the legacy parser tries to paragraph wrap the aside, because it isn't aware of the content model violation. When treebuilding happens, the paragraph gets split leading to the empty paragraphs.

The problem isn't Parsoid per se, it's Parsoid copying the legacy parser bug for bug. If you inspect the extension content coming from the legacy parser in a read view, you'll see the empty paragraphs that are suppressed with css.

The proposed fix is fine but we should do it in the legacy parser first.

Arlolra triaged this task as Medium priority.Mar 31 2021, 4:26 PM

Arlolra moved this task from Needs Triage to Missing Functionality on the Parsoid board.

Change 676108 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/core@master] Don't p-wrap <aside> tags in extension HTML

https://gerrit.wikimedia.org/r/676108

SlyCooperFan1 subscribed.Apr 5 2021, 12:56 AM

Change 676108 merged by jenkins-bot:

[mediawiki/core@master] Don't p-wrap <aside> tags in extension HTML

https://gerrit.wikimedia.org/r/676108

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 7:00 PM

Change 682741 had a related patch set uploaded (by Arlolra; author: TK-999):