Page MenuHomePhabricator

Replace deprecated @codingStandardsIgnore in repos running codesniffer
Closed, ResolvedPublic

Description

The next major version of the codesniffer (which is 4.0) would remove the @codingStandardsIgnore... annotations, which could be replaced by phpcs:.... or @phpcs:.... before a new version is released.

The annotation are most used to disabled all sniffs, but in the future there should be used to only disable/ignore the sniff which is needed like the LineLength sniff

https://codesearch.wmcloud.org/search/?q=%40codingStandardsIgnore&i=nope&files=&excludeFiles=&repos=

Not sure if codesniffer could warn on this tags, because there are usually suppressing all sniffs

Doxygen needs cleanup on some repos:
https://codesearch.wmcloud.org/search/?q=%5B%5E%40%5DcodingStandardsIgnore&i=nope&files=&excludeFiles=&repos=

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bartosz Dziewońskimediawiki/extensions/Wikibasemaster+5 -10
Bartosz Dziewońskimediawiki/extensions/WikiLambdamaster+1 -1
Bartosz Dziewońskimediawiki/extensions/ImageSuggestionsmaster+10 -20
Bartosz Dziewońskimediawiki/libs/php-cssjanusmaster+2 -2
VolkerEmediawiki/coremaster+356 -404
Umherirrenderoojs/uimaster+4 -5
Umherirrendermediawiki/extensions/MachineVisionmaster+5 -9
Umherirrendermediawiki/extensions/ReadingListsmaster+5 -9
Umherirrendermediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Umherirrendermediawiki/coremaster+23 -50
Umherirrendermediawiki/extensions/Scribuntomaster+14 -5
Umherirrendermediawiki/extensions/Translatemaster+28 -30
Umherirrendermediawiki/extensions/QuizGamemaster+12 -12
Umherirrendermediawiki/extensions/WikibaseManifestmaster+2 -2
Umherirrendermediawiki/extensions/GWToolsetmaster+3 -4
Umherirrendermediawiki/extensions/MobileFrontendmaster+12 -20
Umherirrendermediawiki/extensions/MediaUploadermaster+0 -12
Umherirrendermediawiki/extensions/AJAXPollmaster+16 -13
Umherirrendermediawiki/extensions/Commentsmaster+6 -6
Umherirrendermediawiki/extensions/Citoidmaster+5 -4
Umherirrendermediawiki/extensions/LDAPProvidermaster+4 -2
Umherirrendermediawiki/extensions/WikibaseLexememaster+1 -3
Umherirrendermediawiki/extensions/VisualEditormaster+0 -2
Umherirrendermediawiki/extensions/JsonConfigmaster+4 -3
Umherirrendermediawiki/extensions/Calendarmaster+0 -2
Umherirrendermediawiki/extensions/ReplaceTextmaster+2 -7
Umherirrendermediawiki/extensions/UploadWizardmaster+0 -14
Umherirrendermediawiki/extensions/ParserFunctionsmaster+1 -2
Umherirrendermediawiki/extensions/CodeReviewmaster+2 -2
Umherirrendermediawiki/extensions/TwoColConflictmaster+6 -6
Umherirrendermediawiki/extensions/DoubleWikimaster+3 -2
Umherirrendermediawiki/extensions/Josamaster+5 -5
Umherirrendermediawiki/extensions/ImageRatingmaster+0 -2
Umherirrendermediawiki/extensions/LabeledSectionTransclusionmaster+1 -4
Umherirrendermediawiki/extensions/PhabTaskGraphmaster+1 -3
Umherirrendermediawiki/extensions/PluggableAuthmaster+2 -2
Umherirrendermediawiki/extensions/UseResourcemaster+4 -4
Umherirrendermediawiki/extensions/SafeDeletemaster+1 -2
Umherirrendermediawiki/extensions/VoteNYmaster+3 -2
Umherirrendermediawiki/extensions/wikihieromaster+1 -2
Umherirrendermediawiki/skins/EUCopyrightCampaignSkinmaster+4 -4
Umherirrendermediawiki/extensions/Wikibasemaster+3 -14
Umherirrendermediawiki/extensions/Kartographermaster+6 -6
Umherirrendermediawiki/extensions/SecurePollmaster+5 -9
Umherirrendermediawiki/extensions/TimedMediaHandlermaster+2 -2
Umherirrendermediawiki/extensions/Collectionmaster+1 -10
Umherirrendermediawiki/extensions/CentralAuthmaster+3 -6
Umherirrendermediawiki/extensions/MassMessagemaster+2 -4
Umherirrendermediawiki/extensions/Echomaster+2 -3
Umherirrendermediawiki/extensions/OAuthmaster+2 -2
Umherirrendermediawiki/extensions/PagedTiffHandlermaster+11 -14
Umherirrendermediawiki/libs/IDLeDOMmain+1 -2
Umherirrendermediawiki/libs/Dodomaster+1 -2
Umherirrendermediawiki/extensions/TemplateStylesmaster+23 -38
Umherirrendermediawiki/extensions/BounceHandlermaster+1 -4
Umherirrenderutfnormalmaster+6 -16
Umherirrendercss-sanitizermaster+12 -18
Umherirrendercdbmaster+2 -2
UmherirrenderCLDRPluralRuleParsermaster+12 -13
Umherirrendermediawiki/oauthclient-phpmaster+4 -8
Umherirrendermediawiki/libs/RemexHtmlmaster+3 -4
Umherirrendermediawiki/libs/XMPReadermaster+1 -3
UmherirrenderHtmlFormattermaster+2 -2
Umherirrendermediawiki/libs/ObjectFactorymaster+4 -4
UmherirrenderIPSetmaster+3 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 676754 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseLexeme@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676754

Change 676749 merged by jenkins-bot:

[mediawiki/skins/EUCopyrightCampaignSkin@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676749

Change 676755 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/VoteNY@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676755

Change 676756 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/VisualEditor@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676756

Change 676757 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UseResource@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676757

Change 676750 merged by jenkins-bot:

[mediawiki/extensions/wikihiero@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676750

Change 676758 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TwoColConflict@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676758

Change 676759 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SafeDelete@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676759

Change 676760 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReadingLists@master] Use variadic argument in ApiTrait::requireAtLeastOneBatchParameter

https://gerrit.wikimedia.org/r/676760

Change 676755 merged by jenkins-bot:

[mediawiki/extensions/VoteNY@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676755

Change 676761 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PluggableAuth@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676761

Change 676759 merged by jenkins-bot:

[mediawiki/extensions/SafeDelete@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676759

Change 676757 merged by jenkins-bot:

[mediawiki/extensions/UseResource@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676757

Change 676762 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhabTaskGraph@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676762

Change 676763 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ParserFunctions@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676763

Change 676764 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MachineVision@master] Use variadic argument in ApiTrait::requireAtLeastOneBatchParameter

https://gerrit.wikimedia.org/r/676764

Change 676761 merged by jenkins-bot:

[mediawiki/extensions/PluggableAuth@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676761

Change 676765 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LDAPProvider@master] build: Swap deprecated @codingStandardsIgnore to exclude in .phpcs.xml

https://gerrit.wikimedia.org/r/676765

Change 676766 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LabeledSectionTransclusion@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676766

Change 676767 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/JsonConfig@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676767

Change 676768 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Josa@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676768

Change 676769 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ImageRating@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676769

Change 676770 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/DoubleWiki@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676770

Change 676771 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CodeReview@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676771

Change 676772 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Calendar@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676772

Change 676773 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UploadWizard@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676773

Change 676774 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Scribunto@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676774

Change 676775 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ReplaceText@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676775

Change 676762 merged by jenkins-bot:

[mediawiki/extensions/PhabTaskGraph@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676762

Change 676758 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676758

Change 676766 merged by jenkins-bot:

[mediawiki/extensions/LabeledSectionTransclusion@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676766

Change 676769 merged by jenkins-bot:

[mediawiki/extensions/ImageRating@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676769

Change 676768 merged by jenkins-bot:

[mediawiki/extensions/Josa@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676768

Change 676770 merged by jenkins-bot:

[mediawiki/extensions/DoubleWiki@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676770

Change 676771 merged by jenkins-bot:

[mediawiki/extensions/CodeReview@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676771

Change 676763 merged by jenkins-bot:

[mediawiki/extensions/ParserFunctions@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676763

Change 676773 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676773

Change 676767 merged by jenkins-bot:

[mediawiki/extensions/JsonConfig@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676767

Change 676775 merged by jenkins-bot:

[mediawiki/extensions/ReplaceText@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676775

Change 676772 merged by jenkins-bot:

[mediawiki/extensions/Calendar@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676772

Change 676756 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676756

Change 676754 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676754

Change 676752 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676752

Change 676818 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GWToolset@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676818

Change 676819 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676819

Change 676821 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/QuizGame@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676821

Change 676823 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Comments@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676823

Change 676824 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AJAXPoll@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676824

Change 676825 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MobileFrontend@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676825

Change 676827 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Citoid@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676827

Change 676830 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MediaUploader@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676830

Change 676765 merged by jenkins-bot:

[mediawiki/extensions/LDAPProvider@master] build: Swap deprecated @codingStandardsIgnore to exclude in .phpcs.xml

https://gerrit.wikimedia.org/r/676765

Change 676827 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676827

Change 676825 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676825

Change 676830 merged by jenkins-bot:

[mediawiki/extensions/MediaUploader@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676830

Change 676823 merged by jenkins-bot:

[mediawiki/extensions/Comments@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676823

Change 676824 merged by jenkins-bot:

[mediawiki/extensions/AJAXPoll@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676824

Change 676818 merged by jenkins-bot:

[mediawiki/extensions/GWToolset@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676818

Change 676751 merged by jenkins-bot:

[mediawiki/extensions/WikibaseManifest@master] build: Swap deprecated @codingStandardsIgnore to phpcs:disable

https://gerrit.wikimedia.org/r/676751

Change 676836 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676836

Change 676819 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676819

Change 676821 merged by jenkins-bot:

[mediawiki/extensions/QuizGame@master] build: Remove unneeded @codingStandardsIgnore

https://gerrit.wikimedia.org/r/676821

Change 676836 merged by jenkins-bot:

[mediawiki/core@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676836

Change 676774 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] build: Swap deprecated @codingStandardsIgnore to phpcs:ignore

https://gerrit.wikimedia.org/r/676774

Change 676760 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Use variadic argument in ApiTrait::requireAtLeastOneBatchParameter

https://gerrit.wikimedia.org/r/676760

Change 676764 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] Use variadic argument in ApiTrait::requireAtLeastOneBatchParameter

https://gerrit.wikimedia.org/r/676764

Change 713803 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803

Change 713803 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.42.0

https://gerrit.wikimedia.org/r/713803

matmarex assigned this task to Umherirrender.
matmarex subscribed.

This looks to have been done back in 2021. There are only a few uses of @codingStandardsIgnore in our repos now, and they're mostly in new code, they were probably re-introduced later. I'll submit some patches, but I think this was resolved.

Change #1169678 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/libs/php-cssjanus@master] Swap deprecated @codingStandardsIgnoreStart/End to phpcs:disable/enable

https://gerrit.wikimedia.org/r/1169678

Change #1169679 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/ImageSuggestions@master] Swap deprecated @codingStandardsIgnore... to phpcs:...

https://gerrit.wikimedia.org/r/1169679

Change #1169680 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Wikibase@master] Swap deprecated @codingStandardsIgnore... to phpcs:...

https://gerrit.wikimedia.org/r/1169680

Change #1169682 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikiLambda@master] Swap deprecated @codingStandardsIgnoreLine to phpcs:ignore

https://gerrit.wikimedia.org/r/1169682

Change #1169679 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Swap deprecated @codingStandardsIgnore... to phpcs:...

https://gerrit.wikimedia.org/r/1169679

Change #1169682 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Swap deprecated @codingStandardsIgnoreLine to phpcs:ignore

https://gerrit.wikimedia.org/r/1169682

Change #1169680 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Swap deprecated @codingStandardsIgnore... to phpcs:...

https://gerrit.wikimedia.org/r/1169680