Preview pagelist button on non-dialogue portion should not be active when closing the dialogue
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Soda
	Mar 27 2021, 10:17 AM

Project Tags

Referenced Files

None

Subscribers

Description

Currently, when the Pagelist Widget's dialogue window is closed, the preview is reloaded.

During this time, the Preview Pagelist button (above the preview) is not disabled and the user can trigger another reload, while the preview is reloading.

Ideally, this button should be disabled so that another reload cannot be triggered while the current one is still happening.

Documentation

Tutorial on setting up and working with Gerrit (Gerrit is Wikimedia's code review platform)
File that needs to be modified: PagelistInputWidget.js, PagelistInputWidget.PagelistPreview.js
OOUI (the framework used to build the PagelistWidget)
OOJS Events

Criteria

Emit a new event in PagelistPreview that signifies that the reload has started.
Hook a function that set's the Preview Pagelist button's state to disabled when the event is fired.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Preview pagelist button on non-dialogue portion should not be active when closing the dialogue	Yash9265	mediawiki/extensions/ProofreadPage	master	+11 -1

Customize query in gerrit

Event Timeline

Soda created this task.Mar 27 2021, 10:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2021, 10:17 AM

Yash4357 claimed this task.Mar 27 2021, 10:29 AM

Soda added subscribers: Samwilson, SGautam_WMF.Mar 27 2021, 10:31 AM

Soda edited subscribers, added: SGill; removed: SGautam_WMF.

Soda moved this task from Backlog to Pagelist Widget on the ProofreadPage board.Mar 27 2021, 10:55 AM

Change 675324 had a related patch set uploaded (by Yash9265; author: Yash9265):
[mediawiki/extensions/ProofreadPage@master] Preview pagelist button on non-dialogue portion should not be active when closing the dialogue

https://gerrit.wikimedia.org/r/675324

gerritbot added a project: Patch-For-Review.Mar 28 2021, 10:15 AM

Change 675324 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Preview pagelist button on non-dialogue portion should not be active when closing the dialogue

https://gerrit.wikimedia.org/r/675324

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 13 2021, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2021, 1:11 PM

@Yash4357: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action... → Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!

Yash4357 closed this task as Resolved.May 24 2021, 7:18 AM

Preview pagelist button on non-dialogue portion should not be active when closing the dialogueClosed, ResolvedPublicActions