Page MenuHomePhabricator

Preview pagelist button on non-dialogue portion should not be active when closing the dialogue
Closed, ResolvedPublic

Description

Currently, when the Pagelist Widget's dialogue window is closed, the preview is reloaded.

During this time, the Preview Pagelist button (above the preview) is not disabled and the user can trigger another reload, while the preview is reloading.

Ideally, this button should be disabled so that another reload cannot be triggered while the current one is still happening.

Documentation

Criteria

  • Emit a new event in PagelistPreview that signifies that the reload has started.
  • Hook a function that set's the Preview Pagelist button's state to disabled when the event is fired.

Event Timeline

Soda edited subscribers, added: SGill; removed: SGautam_WMF.

Change 675324 had a related patch set uploaded (by Yash9265; author: Yash9265):
[mediawiki/extensions/ProofreadPage@master] Preview pagelist button on non-dialogue portion should not be active when closing the dialogue

https://gerrit.wikimedia.org/r/675324

Change 675324 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Preview pagelist button on non-dialogue portion should not be active when closing the dialogue

https://gerrit.wikimedia.org/r/675324

@Yash4357: Hi, the patch in Gerrit has been merged. Can this task be resolved (via Add Action...Change Status in the dropdown menu), or is there more to do in this task? Asking as you are set as task assignee. Thanks in advance!