⚓ T278651 Add rate limits and rights for each part of the system

Status	Subtype	Assigned	Task
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T344206 Special:MathStatus exception error on Wikifunctions
Resolved		Jdforrester-WMF	T342865 Post-creation work for wikifunctionswiki
Resolved		BTullis	T289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
Resolved		Jdforrester-WMF	T275945 Create Wikifunctions.org
Resolved		Jdforrester-WMF	T299176 Phase Theta – Root task
Resolved		cmassaro	T299596 Add security limits to the Wikifunctions system to maintain availability and load factors
Resolved		Jdforrester-WMF	T282913 Implement agreed security and control measures in the Wikifunctions system
Resolved		Jdforrester-WMF	T278651 Add rate limits and rights for each part of the system
Resolved		Jdforrester-WMF	T282914 Provide user rights for editing of ZObjects at all, and specific ones for ZImplementations, ZTesters, and ZFunctions

Bugreporter created this task.Mar 28 2021, 4:29 PM

Let's use this as the Epic for all the stuff here.

Jdforrester-WMF renamed this task from Add rate limit for evaluating functions to Add rate limits and rights for each part of the system.Mar 31 2021, 6:14 PM

Jdforrester-WMF added projects: WikiLambda, function-orchestrator, function-evaluator, Epic.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added a subtask: T275940: Split out the nature of different edits to check against different rights.

Jdforrester-WMF moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.

Jdforrester-WMF mentioned this in T271762: Create initial Function Evaluator service.May 14 2021, 12:14 AM

Jdforrester-WMF added a parent task: T282913: Implement agreed security and control measures in the Wikifunctions system.May 15 2021, 12:26 AM

Initial starter-for-ten idea of which rights we'll have, discussed with @DVrandecic

* Logged-out users can:
    * Run an associated Impl via the API / Transclusion / Direct
    * Edit labels/etc.

* Logged-in users can:
    * Create Function definitions
    * Create Testers
    * Create implementations
    * (?Auto-)Associate Testers iff they pass all associated implementations
    * Trigger a test run again. (?)
    * Run directly an unassociated Impl. that they've created
        (Maybe very strict limits on running it manually?)

* Reviewers/Coders can:
    * Run any Impl. directly, whether or not it's unassociated
    * Associate Imps even if they don't pass any of the Testers
    * Associate Testers even if they don't pass on one or more Imps
    * De-associate Imps and Testers
    * Edit existing Impls and Testers ((?auto-)associated)
        Maybe a checkbox to not auto-associate.

* No-one can:
    * Run an unassoc. Impl. via the API or Transclude

Quiddity subscribed.Jul 28 2021, 8:19 PM

+ Logged-in users can edit unassociated implementations and testers?

Suggestions to add:

Logged-in users can:
- associate an Implementation that passes all tests and when there is no implementation yet (debated) to allow the full "create a function flow" to logged in users
- edit unassociated implementations and testers

Ameisenigel subscribed.Jul 31 2021, 1:10 PM

Jdforrester-WMF added a parent task: T299596: Add security limits to the Wikifunctions system to maintain availability and load factors.Jan 19 2022, 10:21 PM

Jdforrester-WMF removed a subtask: T275940: Split out the nature of different edits to check against different rights.Mar 8 2022, 10:28 PM

Jdforrester-WMF moved this task from Incoming to Ready: G2. Correct & efficient on the Abstract Wikipedia team (Phase θ – Throttling) board.Apr 18 2022, 6:41 PM

Jdforrester-WMF triaged this task as Medium priority.Apr 19 2022, 4:29 PM

Jdforrester-WMF moved this task from Ready: G2. Correct & efficient to Ready: G6. Stable & secure on the Abstract Wikipedia team (Phase θ – Throttling) board.Nov 21 2022, 8:30 PM

Needs to be done, but should be pretty simple.
Create a list of all rights ( T282914 )
Need to implement them
Rate limits covered by other tasks
James's estimated effort: 3 days (if whoever picks this up thinks that will take considerably longer, please check whether we agree on the task)