Page MenuHomePhabricator
Create Task
Maniphest T278656

Update SVGO to v2.x including new JS based configuration
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Volker_E
Authored By
Volker_E
Mar 28 2021, 9:05 PM
Tags
Referenced Files
None
Subscribers
Aklapper
bwang
Jdforrester-WMF
Jdrewniak
Ladsgroup
Masumrezarock100
TheDJ
Volker_E

Description

SVGO has been updated to new major version 2.x after some time without any updates.

It needs to be switched to JS configuration.
First exemplary configuration is in Vector.

Production uses:

  • Wikimedia Design Style Guide

Details

SubjectRepoBranchLines +/-
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/coremaster+160 -388
build: Update 'svgo' to latestmediawiki/skins/VectorREL1_36+2 K -2 K
build: Update SVGO to latest v2.3.0 and re-optimize SVGsmediawiki/extensions/UniversalLanguageSelectormaster+818 -1 K
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/skins/Timelessmaster+366 -387
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/CentralNoticemaster+831 -1 K
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/Kartographermaster+204 -328
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/Echomaster+1 K -2 K
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/skins/MonoBookmaster+224 -496
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/TwoColConflictmaster+223 -231
build: Update SVGO to latest v2.3.0 and re-crush SVGsmediawiki/extensions/RevisionSlidermaster+171 -422
build: Upgrade 'svgo' & re-crush SVGsmediawiki/extensions/Popupsmaster+23 K -22 K
Replace grunt-svgmin with SVGO v2.3.0 and run through npm script.mediawiki/extensions/GuidedTourmaster+211 -345
build: Upgrade to latest 'svgo' and re-crush SVGsmediawiki/extensions/MobileFrontendmaster+1 K -1 K
build: Upgrade 'svgo' to latest and re-crush SVGsmediawiki/skins/MinervaNeuemaster+234 -128
build: Update 'svgo' to latestmediawiki/skins/Vectormaster+2 K -2 K
build: Replace 'grunt-svgmin' with npm based 'svgo' & re-crush SVGsmediawiki/extensions/MultimediaViewermaster+7 K -431
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2021, 9:05 PM
Jdlrobson moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Mar 29 2021, 8:12 PM
Volker_E updated the task description. (Show Details)Apr 11 2021, 5:13 PM
Volker_E added a subscriber: bwang.
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptApr 11 2021, 5:13 PM
gerritbot added a comment.Apr 11 2021, 6:06 PM

Change 678403 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MobileFrontend@master] build: Updgrade to latest 'svgo' and re-crush SVGs

https://gerrit.wikimedia.org/r/678403

gerritbot added a project: Patch-For-Review.Apr 11 2021, 6:06 PM
gerritbot added a comment.Apr 12 2021, 8:03 PM

Change 678635 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MultimediaViewer@master] build: Replace 'grunt-svgmin' with npm based 'svgo' & re-crush SVGs

https://gerrit.wikimedia.org/r/678635

gerritbot added a comment.Apr 12 2021, 8:36 PM

Change 678637 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MinervaNeue@master] build: Updgrade to latest 'svgo' and re-crush SVGs

https://gerrit.wikimedia.org/r/678637

Jdforrester-WMF updated the task description. (Show Details)Apr 12 2021, 9:06 PM
Jdforrester-WMF updated the task description. (Show Details)Apr 12 2021, 9:09 PM
gerritbot added a comment.Apr 12 2021, 9:09 PM

Change 678635 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] build: Replace 'grunt-svgmin' with npm based 'svgo' & re-crush SVGs

https://gerrit.wikimedia.org/r/678635

gerritbot added a comment.Apr 12 2021, 9:10 PM

Change 678639 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] build: Update 'svgo' to latest

https://gerrit.wikimedia.org/r/678639

Jdforrester-WMF updated the task description. (Show Details)Apr 12 2021, 9:12 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 12 2021, 10:00 PM
Volker_E updated the task description. (Show Details)Apr 12 2021, 10:10 PM
Volker_E added a subscriber: Jdforrester-WMF.

@Jdforrester-WMF I guess with your expansion, you're in agreement to move all those products over to npm 'svgo' instead of 'grunt-svgmin'? :)

Jdforrester-WMF added a comment.Apr 12 2021, 10:14 PM
In T278656#6992464, @Volker_E wrote:

@Jdforrester-WMF I guess with your expansion, you're in agreement to move all those products over to npm 'svgo' instead of 'grunt-svgmin'? :)

I've given up expecting people to actually help out with finding and making everything that expects Grunt to instead work with npm scripts, so I guess I'll just have to cope and fix them all myself.

Jdlrobson added a project: Web-Team-Backlog-Archived (Kanbanana-FY-2020-21).Apr 15 2021, 5:03 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.
ovasileva triaged this task as Medium priority.Apr 15 2021, 5:10 PM
LGoto assigned this task to Jdrewniak.Apr 15 2021, 5:10 PM
gerritbot added a comment.Apr 19 2021, 1:50 PM

Change 678639 merged by jenkins-bot:

[mediawiki/skins/Vector@master] build: Update 'svgo' to latest

https://gerrit.wikimedia.org/r/678639

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 19 2021, 2:00 PM
LGoto set the point value for this task to 2.Apr 20 2021, 5:45 PM
Jdrewniak updated the task description. (Show Details)Apr 20 2021, 9:11 PM
gerritbot added a comment.Apr 20 2021, 9:31 PM

Change 678637 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] build: Upgrade 'svgo' to latest and re-crush SVGs

https://gerrit.wikimedia.org/r/678637

gerritbot added a comment.Apr 20 2021, 9:37 PM

Change 678403 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] build: Upgrade to latest 'svgo' and re-crush SVGs

https://gerrit.wikimedia.org/r/678403

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2021, 10:10 PM
gerritbot added a comment.Apr 21 2021, 6:05 PM

Change 681760 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/Popups@master] Build: Replace 'grunt-svgmin' with npm based 'svgo' & re-crush SVGs

https://gerrit.wikimedia.org/r/681760

gerritbot added a project: Patch-For-Review.Apr 21 2021, 6:06 PM
Jdlrobson edited projects, added MediaWiki-extensions-GuidedTour, Maps (Kartographer), Revision-Slider, Page-Previews, Two-Column-Edit-Conflict-Merge, UniversalLanguageSelector, MonoBook, Timeless, Notifications (Echo), Cite, MediaWiki-extensions-CentralNotice, MediaWiki-User-Interface; removed Web-Team-Backlog-Archived (Kanbanana-FY-2020-21), MediaWiki-Core-Skin-Architecture.Apr 21 2021, 7:08 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 21 2021, 7:08 PM
gerritbot added a comment.Apr 22 2021, 10:11 AM

Change 681944 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/extensions/GuidedTour@master] Replace grunt-svgmin with SVGO v2.3.0 and run through npm script.

https://gerrit.wikimedia.org/r/681944

gerritbot added a comment.Apr 22 2021, 1:42 PM

Change 681944 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Replace grunt-svgmin with SVGO v2.3.0 and run through npm script.

https://gerrit.wikimedia.org/r/681944

Jdrewniak mentioned this in rEGTOa40fd3af283b: Replace grunt-svgmin with SVGO v2.3.0 and run through npm script..Apr 22 2021, 1:56 PM
MSantos added a project: Product-Infrastructure-Team-Backlog-Deprecated.Apr 26 2021, 12:28 PM
gerritbot added a comment.Apr 28 2021, 7:51 AM

Change 681760 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] build: Upgrade 'svgo' & re-crush SVGs

https://gerrit.wikimedia.org/r/681760

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.4; 2021-05-04); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 28 2021, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2021, 8:10 AM
Izno moved this task from Unsorted backlog to Enhancement backlog on the Cite board.May 1 2021, 1:52 AM
Volker_E updated the task description. (Show Details)May 4 2021, 11:17 AM
kostajh moved this task from Inbox to Triaged on the Growth-Team board.May 4 2021, 1:57 PM
gerritbot added a comment.May 17 2021, 10:50 PM

Change 692446 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Kartographer@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692446

gerritbot added a project: Patch-For-Review.May 17 2021, 10:50 PM
Volker_E updated the task description. (Show Details)May 17 2021, 11:00 PM
Volker_E updated the task description. (Show Details)May 17 2021, 11:11 PM
gerritbot added a comment.May 17 2021, 11:27 PM

Change 692450 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Echo@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692450

gerritbot added a comment.May 18 2021, 12:17 AM

Change 692455 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/CentralNotice@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692455

gerritbot added a comment.May 18 2021, 12:47 AM

Change 692458 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/RevisionSlider@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692458

Volker_E updated the task description. (Show Details)May 18 2021, 12:57 AM
gerritbot added a comment.May 18 2021, 9:06 AM

Change 692458 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692458

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.7; 2021-05-25); removed MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).May 18 2021, 10:00 AM
Volker_E updated the task description. (Show Details)May 18 2021, 10:33 AM
gerritbot added a comment.May 18 2021, 10:50 AM

Change 692580 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/TwoColConflict@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692580

gerritbot added a comment.May 18 2021, 11:15 AM

Change 692580 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692580

Restricted Repository Identity mentioned this in rESCCa88b8d7951e6: build: Update SVGO to latest v2.3.0 and re-crush SVGs.May 18 2021, 11:17 AM
gerritbot added a comment.May 18 2021, 11:18 AM

Change 692584 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/UniversalLanguageSelector@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692584

Volker_E updated the task description. (Show Details)May 18 2021, 11:24 AM
Volker_E mentioned this in T283068: Add SVGO to Wikimedia deployed extensions.May 18 2021, 11:30 AM
gerritbot added a comment.May 18 2021, 12:50 PM

Change 692591 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692591

Volker_E updated the task description. (Show Details)May 18 2021, 12:50 PM
gerritbot added a comment.May 18 2021, 1:07 PM

Change 692595 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Timeless@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692595

gerritbot added a comment.May 18 2021, 1:13 PM

Change 692596 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/MonoBook@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692596

Volker_E claimed this task.May 18 2021, 1:14 PM
Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: Jdrewniak.
gerritbot added a comment.May 18 2021, 10:29 PM

Change 692591 merged by jenkins-bot:

[mediawiki/core@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692591

Volker_E updated the task description. (Show Details)May 27 2021, 1:07 PM
gerritbot added a comment.May 27 2021, 7:03 PM

Change 692450 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692450

gerritbot added a comment.May 27 2021, 7:03 PM

Change 692596 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692596

Restricted Repository Identity mentioned this in rSMNBa80be96c35ba: build: Update SVGO to latest v2.3.0 and re-crush SVGs.May 27 2021, 7:04 PM
gerritbot added a comment.May 27 2021, 7:06 PM

Change 692446 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692446

gerritbot added a comment.May 27 2021, 7:52 PM

Change 692455 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692455

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.9; 2021-06-07); removed MW-1.37-notes (1.37.0-wmf.7; 2021-05-25).May 27 2021, 8:00 PM
gerritbot added a comment.May 27 2021, 8:09 PM

Change 692584 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] build: Update SVGO to latest v2.3.0 and re-optimize SVGs

https://gerrit.wikimedia.org/r/692584

gerritbot added a comment.May 27 2021, 8:09 PM

Change 692595 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] build: Update SVGO to latest v2.3.0 and re-crush SVGs

https://gerrit.wikimedia.org/r/692595

MSantos moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Jun 14 2021, 10:26 AM
gerritbot added a comment.Jun 21 2021, 6:51 PM

Change 700629 had a related patch set uploaded (by Voidwalker; author: VolkerE):

[mediawiki/skins/Vector@REL1_36] build: Update 'svgo' to latest

https://gerrit.wikimedia.org/r/700629

Volker_E updated the task description. (Show Details)Jun 21 2021, 7:13 PM
gerritbot added a comment.Jun 21 2021, 8:42 PM

Change 700629 merged by jenkins-bot:

[mediawiki/skins/Vector@REL1_36] build: Update 'svgo' to latest

https://gerrit.wikimedia.org/r/700629

Jdlrobson moved this task from Backlog to Tech debt on the MonoBook board.Jul 1 2021, 11:06 PM
TheDJ subscribed.Nov 12 2021, 8:31 PM

@Volker_E i think this can be closed ?

Volker_E added a comment.Jan 19 2022, 8:58 AM

@TheDJ Design Style Guide was still missing. Tackled in https://github.com/wikimedia/WikimediaUI-Style-Guide/pull/495 together with new SVGO v2.8 config.

Volker_E added a project: SVG.Feb 6 2022, 8:17 PM
Volker_E closed this task as Resolved.Feb 7 2022, 1:17 PM
Volker_E added a subscriber: Ladsgroup.

DSG PR gladly merged with help of @Ladsgroup!

Volker_E removed a project: Patch-For-Review.Feb 7 2022, 1:18 PM
Volker_E updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits