Page MenuHomePhabricator
Create Task
Maniphest T278690

Split WikibaseRepo AliasTermBuffer service from TermBuffer
Closed, ResolvedPublic
Actions

Description

Currently, WikibaseRepo::getTermBuffer() returns TermBuffer|AliasTermBuffer according to the phpdoc, which is really two services (though with a shared implementation). Split them up.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
repo: extract AliasTermBuffer serviceLucas Werkmeister (WMDE)mediawiki/extensions/Wikibasemaster+49 -8
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 29 2021, 1:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2021, 1:00 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikibase Service Migration board.Mar 29 2021, 1:00 PM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 29 2021, 1:44 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Waiting for other services on the Wikibase Service Migration board.

On second thought, since the main AliasTermBuffer user is EntityTerms, and that is very closely related to client PageTerms, let’s wait with this task until client’s TermBuffer is also migrated. (I.e., this waits not just for T277774 but also for T277897.)

Lucas_Werkmeister_WMDE mentioned this in T279073: Split WikibaseClient AliasTermBuffer service from TermBuffer.Apr 1 2021, 4:00 PM
ItamarWMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 6 2021, 3:43 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 6 2021, 3:54 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 6 2021, 4:14 PM

Change 677300 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: extract AliasTermBuffer service

https://gerrit.wikimedia.org/r/677300

gerritbot added a project: Patch-For-Review.Apr 6 2021, 4:14 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 6 2021, 4:15 PM
gerritbot added a comment.Apr 6 2021, 6:44 PM

Change 677300 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: extract AliasTermBuffer service

https://gerrit.wikimedia.org/r/677300

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 6 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 6 2021, 7:10 PM
ItamarWMDE closed this task as Resolved.Apr 7 2021, 6:37 AM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits