WikibaseClient has three well-known entity sources (available as services in the service container):
- ItemSource, the source for the item entity type
- PropertySource, the source for the property entity type
- ItemAndPropertySource, the source whose name matches the itemAndPropertySourceName setting
This doesn’t really make sense. ItemAndPropertySource presupposes that items and properties always come from the same entity source, which would make the other two sources redundant; but in fact, this is no longer the case, especially with Wikibase - Federated Properties. In reality (if I understand correctly), ItemAndPropertySource is a renamed (T258060) holdover from a time when there was such a thing as the repo to which a client was connected. I think we should remove it, and instead use the right entity source for each entity type everywhere.