Page MenuHomePhabricator

Bracket matching loses highlight when scrolling
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

When brackets are matched and the edit area loses the focus, e.g. by moving the vertical scrollbar, the highlighting of the brackets - in difference to all other highlighting - disappears. This is a problem when the matching brackets are far apart.

The problem might be that erasing the highlighting is a function of the event "losing focus", because without focus the caret (inserting position) is undefined. Maybe, the problem will be solved when erasing the highlighting is like setting a new one a function of setting the caret.

Taken from https://meta.wikimedia.org/wiki/Talk:Community_Tech/Wikitext_editor_syntax_highlighting#matching_brackets

Event Timeline

Change 678212 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Fix incomplete (auto)clear for highlighted brackets

https://gerrit.wikimedia.org/r/678212

thiemowmde changed the subtype of this task from "Task" to "Bug Report".
thiemowmde set the point value for this task to 2.
thiemowmde moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-03-31 board.

Change 678212 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Fix incomplete (auto)clear for highlighted brackets

https://gerrit.wikimedia.org/r/678212

Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-03-31 board.

Change 682123 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Fix bracket matching getting stuck when leaving the brackets

https://gerrit.wikimedia.org/r/682123

Change 682123 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Fix bracket matching getting stuck when leaving the brackets

https://gerrit.wikimedia.org/r/682123