Page MenuHomePhabricator

Keyboard navigation broken for "Search for pages containing" if exact match exists
Closed, ResolvedPublic3 Estimated Story Points

Description

It should be possible to use the keyboard to navigate to the Search results page, by typing a search, then tapping [up] and [enter]. It is currently not possible, if an exact match exists.

This seems to have changed recently. It is currently working as expected in meta-wiki, but not working in beta cluster or officewiki.

Steps to reproduce:

  • Type text into search box - Any text which matches an existing page title.
  • Click the [up arrow], which will select the bottom item, "Search for pages containing [....]"
  • Click [enter]

Expected results:

  • The Special:Search page loads showing a the search results for the typed text

Current results:

  • The existing wiki-page is loaded

E.g.

(I'm using Firefox on Mint-linux, if that matters)

QA Results - Beta (Storybook)

ACStatusDetails
1T278880#7036649
2T278880#7036649

QA Results - Prod

ACStatusDetails
1T278880#7147711
2T278880#7147711

Event Timeline

Jdlrobson added a subscriber: Jdlrobson.

Hitting enter submits the form, rather than navigating to "search in pages"

I was able to reproduce this in the beta cluster that was linked to, but cannot reproduce this on enwiki or officewiki, where the behavior is as expected. Are you still having issues with this beyond the beta cluster?

@MPhamWMF Yes, if I turn off "Use Legacy Vector" on officewiki, and try to search for "fundraising", then it sends me to the page instead.

I also noticed that the searchbox styling is different at those 2 wikis, with the magnifying glass icon appearing at the left instead of the right, so there's definitely something different going on at those 2. (but I don't see that "left-icon" styling at other phase 0 wikis, so I assume it's not related to deployment train?) Hope that helps!

image.png (516×776 px, 79 KB)

This problem is now reproducible on Enwiki / Meta-wiki / MediaWiki-wiki.

Don't worry it's clear how to reproduce this and what needs to be done to fix it. Work just needs to be prioritized.

cjming added a subscriber: cjming.

Change 680344 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[wvui@master] [typeahead-search] Ensure the suggestion footer works the same on keyboard and mouse

https://gerrit.wikimedia.org/r/680344

bwang removed bwang as the assignee of this task.Apr 16 2021, 8:54 PM
bwang assigned this task to nray.
bwang added a subscriber: bwang.
bwang removed a subscriber: bwang.
ovasileva added a subscriber: nray.

Change 680344 merged by jenkins-bot:

[wvui@master] [typeahead-search] Ensure the suggestion footer works the same on keyboard and mouse.

https://gerrit.wikimedia.org/r/680344

Edtadros added a subscriber: Edtadros.

Test Result - Beta

Status: ❌ Fail
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Type text into search box - Any text which matches an existing page title.
Click the [up arrow], which will select the bottom item, "Search for pages containing [....]"
Click [enter]

❌ AC1: The Special:Search page loads showing the search results for the typed text

Screen Recording 2021-04-22 at 8.49.39 AM.mov.gif (896×1 px, 461 KB)

Jdlrobson added a subscriber: bwang.

Sorry for the confusion here @Edtadros - we haven't done a release yet so the beta cluster will definitely fail until that happens. You'll need to test on storybook in the instance at https://wvui.netlify.app/ui/

@bwang is it possible to test with storyobok here? Is there anything Edward needs to know?

@Edtadros @Jdlrobson Yes it should be possible to test on storybook. You can confirm the patch is fixed by ensuring the steps below result in the same URL. Specifically both URLs should have a "fulltext=1" param.

  1. Suggestion footer via enter

Type text into search box - Any text which matches an existing page title.
Click the [up arrow], which will select the bottom item, "Search for pages containing [....]"
Click [enter]

  1. Suggestion footer via click

Type text into search box - Any text which matches an existing page title.
Use mouse to [click] the bottom item, "Search for pages containing [....]"

Change 682196 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update WVUI to v0.1.1

https://gerrit.wikimedia.org/r/682196

Change 682196 merged by jenkins-bot:

[mediawiki/core@master] Update WVUI to v0.1.1

https://gerrit.wikimedia.org/r/682196

Test Result - Storybook

Status: ✅ PASS
Environment: Storybook
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

You can confirm the patch is fixed by ensuring the steps below result in the same URL. Specifically both URLs should have a "fulltext=1" param.

Suggestion footer via enter
Type text into search box - Any text which matches an existing page title.
Click the [up arrow], which will select the bottom item, "Search for pages containing [....]"
✅ AC1: Click [enter]

Screen Recording 2021-04-26 at 7.55.27 PM.mov.gif (836×1 px, 240 KB)

Suggestion footer via click
Type text into search box - Any text which matches an existing page title.
✅ AC2: Use mouse to [click] the bottom item, "Search for pages containing [....]"

Screen Recording 2021-04-26 at 7.56.10 PM.mov.gif (836×1 px, 189 KB)

@bwang / @Jdlrobson does this still need to be validated in beta, or is storybook sufficient for "beta"

Test Result - Prod

Status: ❌ Fail
Environment: Prod
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

You can confirm the patch is fixed by ensuring the steps below result in the same URL. Specifically both URLs should have a "fulltext=1" param.

Suggestion footer via enter
Type text into search box - Any text which matches an existing page title.
Click the [up arrow], which will select the bottom item, "Search for pages containing [....]"
❌ AC1: Click [enter]

Screen Recording 2021-05-07 at 9.28.20 PM.mov.gif (862×1 px, 833 KB)

Suggestion footer via click
Type text into search box - Any text which matches an existing page title.
✅ AC2: Use mouse to [click] the bottom item, "Search for pages containing [....]"

Screen Recording 2021-05-07 at 9.30.32 PM.mov.gif (862×1 px, 953 KB)

@bwang, I'm not sure if this is in production. If it isn't yet, please feel free to assign it back to me, put it back in Needs QA in Prod, and just let me know what version it will be available in prod.

@bwang can you provide any update on this one please? It doesn't seem to be working. Is this blocked on a wvui release?

Moving to Needs QA in Prod. I revalidated that it is working in Beta.

Test Result - Prod

Status: ✅ Pass
Environment: hewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

You can confirm the patch is fixed by ensuring the steps below result in the same URL. Specifically both URLs should have a "fulltext=1" param.

Suggestion footer via enter
Type text into search box - Any text which matches an existing page title.
Click the [up arrow], which will select the bottom item, "Search for pages containing [....]"
✅ AC1: Click [enter]

Screen Recording 2021-06-09 at 11.07.02 PM.mov.gif (1×1 px, 1 MB)

Suggestion footer via click
Type text into search box - Any text which matches an existing page title.
✅ AC2: Use mouse to [click] the bottom item, "Search for pages containing [....]"

Screen Recording 2021-06-09 at 11.07.47 PM.mov.gif (1×1 px, 922 KB)