Page MenuHomePhabricator

The interface feature in ResourceLoaderSkinModule contains category styles.
Closed, ResolvedPublic

Description

There is a dedicated feature for interface-category, yet some styling rules for categories are still shipped in the interface feature

acceptance criteria

  • Move the styles from interface into the new interface-category feature.

Event Timeline

Change 675999 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] Move category and editOptions styles out of interface

https://gerrit.wikimedia.org/r/675999

Change 677372 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Example@master] Example skin should use default category styling

https://gerrit.wikimedia.org/r/677372

Screen Shot 2021-04-06 at 2.53.27 PM.png (402×1 px, 49 KB)

Some 3rd party skins may see a slight regression from this change. I don't consider this a breaking change as the interface is still usable and in most skins this will be an improvement on the status quo (see Example skin) example resulting in a better outcome on the longer run:

Before changeAfter changeAfter gerrit:677372
Screen Shot 2021-04-06 at 2.54.00 PM.png (546×2 px, 69 KB)
Screen Shot 2021-04-06 at 2.55.14 PM.png (276×606 px, 26 KB)
Screen Shot 2021-04-06 at 2.50.14 PM.png (182×1 px, 42 KB)

Change 675999 merged by jenkins-bot:

[mediawiki/core@master] Move category and editOptions styles out of interface

https://gerrit.wikimedia.org/r/675999

Jdlrobson updated the task description. (Show Details)

Change 677372 merged by jenkins-bot:

[mediawiki/skins/Example@master] Example skin should use default category styling

https://gerrit.wikimedia.org/r/677372