Page MenuHomePhabricator
Create Task
Maniphest T278925

Move WikibaseRepo EntityRevisionLookup to service container
Closed, ResolvedPublic
Actions

Description

WikibaseRepo::getEntityRevisionLookup() has an optional $cache argument, which we can’t directly include in the migration, but we can use the default mode for the lookup in the service container, use that for all callers that use the default lookup, and migrate the others to call $store->getEntityRevisionLookup( $cache ) directly instead.

Details

SubjectRepoBranchLines +/-
Hard-deprecate WikibaseRepo::getEntityRevisionLookup() with $cachemediawiki/extensions/Wikibasemaster+2 -2
Update WikibaseRepo::getEntityRevisionLookup() callsmediawiki/extensions/WikibaseLexememaster+42 -32
Update WikibaseRepo::getEntityRevisionLookup() callmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -1
repo: move EntityRevisionLookup to service containermediawiki/extensions/Wikibasemaster+134 -36
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 31 2021, 9:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2021, 9:53 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Mar 31 2021, 9:53 AM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 31 2021, 4:13 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 8 2021, 11:04 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 8 2021, 11:48 AM

Change 677854 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] repo: move EntityRevisionLookup to service container

https://gerrit.wikimedia.org/r/677854

gerritbot added a project: Patch-For-Review.Apr 8 2021, 11:48 AM

Change 677855 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityRevisionLookup() calls

https://gerrit.wikimedia.org/r/677855

gerritbot added a comment.Apr 8 2021, 11:48 AM

Change 677856 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityRevisionLookup() call

https://gerrit.wikimedia.org/r/677856

gerritbot added a comment.Apr 8 2021, 11:48 AM

Change 677857 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Hard-deprecate WikibaseRepo::getEntityRevisionLookup() with $cache

https://gerrit.wikimedia.org/r/677857

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 8 2021, 11:49 AM
Lucas_Werkmeister_WMDE mentioned this in T279653: Remove backwards compatibility code from WikibaseRepo::getEntityRevisionLookup().Apr 8 2021, 11:55 AM
gerritbot added a comment.Apr 9 2021, 1:52 PM

Change 677854 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: move EntityRevisionLookup to service container

https://gerrit.wikimedia.org/r/677854

gerritbot added a comment.Apr 9 2021, 1:56 PM

Change 677856 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getEntityRevisionLookup() call

https://gerrit.wikimedia.org/r/677856

gerritbot added a comment.Apr 9 2021, 1:56 PM

Change 677855 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getEntityRevisionLookup() calls

https://gerrit.wikimedia.org/r/677855

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 9 2021, 2:00 PM
gerritbot added a comment.Apr 9 2021, 3:28 PM

Change 677857 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Hard-deprecate WikibaseRepo::getEntityRevisionLookup() with $cache

https://gerrit.wikimedia.org/r/677857

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 9 2021, 3:28 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T278345: 1.37.0-wmf.1 deployment blockers.Apr 9 2021, 3:31 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits