Page MenuHomePhabricator
Create Task
Maniphest T278940

Make LinkCache usable from PageStore
Closed, ResolvedPublic
Actions

Description

LinkCache is currently used as a cache inside Title. It should be changed to allow it to be used from inside PageStore as well. That way, the old and the new way of accessing information from the page table share a cache, and the logic for purging/updating that cache is already in place.

Details

SubjectRepoBranchLines +/-
EXPERIMENT: LinkCache: use PageRecordmediawiki/coremaster+289 -121
PageStore: Use LinkCachemediawiki/coremaster+799 -187
Update LinkCache methods to accept PageIdentitymediawiki/coremaster+349 -19
Make LinkCache behavior more consistentmediawiki/coremaster+566 -66
Customize query in gerrit

Event Timeline

vadim-kovalenko created this task.Mar 31 2021, 11:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2021, 11:44 AM
gerritbot added a comment.Mar 31 2021, 2:06 PM

Change 676078 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/core@master] Update LinkCache methods to accept PageIdentity

https://gerrit.wikimedia.org/r/676078

gerritbot added a project: Patch-For-Review.Mar 31 2021, 2:06 PM
vadim-kovalenko moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.Apr 5 2021, 10:19 AM
daniel renamed this task from Update LinkCache methods to accept PageIdentity to Convert LinkCache to PageRecord.May 11 2021, 5:08 PM
daniel claimed this task.
daniel updated the task description. (Show Details)
gerritbot added a comment.May 11 2021, 8:34 PM

Change 682964 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] EXPERIMENT: LinkCache: use PageRecord

https://gerrit.wikimedia.org/r/682964

gerritbot added a comment.Jun 1 2021, 8:18 PM

Change 697656 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] LinkCache: store DB rows compatible with PageStoreRecord.

https://gerrit.wikimedia.org/r/697656

gerritbot added a comment.Jun 2 2021, 3:51 PM

Change 697803 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] LinkCache: accept Pagereference and other keys

https://gerrit.wikimedia.org/r/697803

gerritbot added a comment.Jun 24 2021, 8:10 PM

Change 697803 merged by jenkins-bot:

[mediawiki/core@master] Make LinkCache behavior more consistent

https://gerrit.wikimedia.org/r/697803

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 24 2021, 9:00 PM
daniel renamed this task from Convert LinkCache to PageRecord to Make LinkCache usable from PageStore.Aug 22 2021, 3:09 PM
daniel updated the task description. (Show Details)
gerritbot added a comment.Sep 9 2021, 8:03 PM

Change 676078 abandoned by Ppchelko:

[mediawiki/core@master] Update LinkCache methods to accept PageIdentity

Reason:

https://gerrit.wikimedia.org/r/676078

• Pchelolo moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Sep 9 2021, 8:04 PM
gerritbot added a comment.Sep 9 2021, 8:04 PM

Change 697656 merged by jenkins-bot:

[mediawiki/core@master] PageStore: Use LinkCache

https://gerrit.wikimedia.org/r/697656

gerritbot added a comment.Sep 10 2021, 8:48 AM

Change 682964 abandoned by Daniel Kinzler:

[mediawiki/core@master] EXPERIMENT: LinkCache: use PageRecord

Reason:

stale

https://gerrit.wikimedia.org/r/682964

Maintenance_bot removed a project: Patch-For-Review.Sep 10 2021, 9:10 AM
• Pchelolo closed this task as Resolved.Sep 27 2021, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL