Page MenuHomePhabricator
Create Task
Maniphest T279073

Split WikibaseClient AliasTermBuffer service from TermBuffer
Closed, ResolvedPublic
Actions

Description

Currently, WikibaseClient::getTermBuffer() returns TermBuffer|AliasTermBuffer according to the phpdoc, which is really two services (though with a shared implementation). Split them up.

Can be done after T277897: WikibaseClient: Move TermBuffer to service container. See also T278690: Split WikibaseRepo AliasTermBuffer service from TermBuffer.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
client: extract AliasTermBuffer servicemediawiki/extensions/Wikibasemaster+49 -8
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 1 2021, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2021, 4:00 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Apr 1 2021, 4:07 PM
ItamarWMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 6 2021, 3:45 PM
Lucas_Werkmeister_WMDE claimed this task.Apr 6 2021, 3:54 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 6 2021, 4:15 PM

Change 677301 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] client: extract AliasTermBuffer service

https://gerrit.wikimedia.org/r/677301

gerritbot added a project: Patch-For-Review.Apr 6 2021, 4:15 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 6 2021, 4:15 PM
gerritbot added a comment.Apr 7 2021, 10:42 AM

Change 677301 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: extract AliasTermBuffer service

https://gerrit.wikimedia.org/r/677301

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 7 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 7 2021, 11:10 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 7 2021, 12:13 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits