| AnneT | |
| Apr 1 2021, 7:52 PM |
| F34544823: Screen Shot 2021-07-09 at 9.16.51 AM.png | |
| Jul 9 2021, 4:37 PM |
As part of our celebratory code-cleanup post-MediaSearch launch, we'd like to clean up some of the to-dos in the code. Note that some of these will get moved to MediaSearch once that extension goes live...
See here: https://github.com/wikimedia/mediawiki-extensions-MediaSearch/search?q=todo
Updated ticket to be about Extension:MediaSearch instead of WBMI.
The other WBMI todos are 1/ things that already have tickets (support for complex search types) or 2/ not related to MediaSearch, and have already been looked into & left behind for good enough reasons.
Looks like there are only 2 more MediaSearch todos left to tackle!
Thanks for reviewing these @matthiasmullie - the QuickView one sounds fun so I'm going to assign this to myself!
Change 699271 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/extensions/MediaSearch@master] Move ensureArray helper function to its own file
Change 702237 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[mediawiki/extensions/MediaSearch@master] Show loading indicator while QuickView data is fetched
Change 699271 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Move ensureArray helper function to its own file
Change 702237 merged by jenkins-bot:
[mediawiki/extensions/MediaSearch@master] Show loading indicator while QuickView data is fetched
Checked in betalabs - moving to Verify in production.
What to check
Checked on commons wmf.14.
Checked in betalabs - moving to Verify in production.
What to check
- "Did you mean?" is displayed (commons betalabs doesn't display "sdms-did-you-mean" )
- refreshing Special:MediaSearch on commons wmf.12 displays:
Filed a follow up minor issue T286688