Page MenuHomePhabricator
Create Task
Maniphest T279113

Unable to parse title at new Title in Special:MediaSearch
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.04.01?id=QsFmj3gBg_6mGHGhNnp7
example URL: https://commons.wikimedia.org/w/index.php?search=Go+down+to+the+man&title=Special:MediaSearch&go=Go&type=image

84 errors from multiple IP addresses in the last 3 hrs means this is notable enough to block the next deploy (or at very least the deploy after that)

error
Error: Unable to parse title
stack_trace
	
at new Title  <anonymous>:392:660
at a.displayName  URL1:538:603
at fn.get  <anonymous>:451:628
at fn.evaluate  <anonymous>:452:778
at a.displayName  <anonymous>:454:682
at a.eval  eval at Ya (:517:517), <anonymous>:3:239
at a.e._render  <anonymous>:460:348
at a.r  <anonymous>:493:746
at fn.get  <anonymous>:451:628
at new fn  <anonymous>:451:546

URL1: https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%7Cjquery.ui%7Cwikibase.mediainfo.mediasearch.vue&skin=vector&version=1pnkb

Details

SubjectRepoBranchLines +/-
Use mw.Title.newFromText() to avoid errorsmediawiki/extensions/WikibaseMediaInfomaster+43 -28
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT278345 1.37.0-wmf.1 deployment blockers
 ResolvedPRODUCTION ERRORAnneTT279113 Unable to parse title at new Title in Special:MediaSearch

Event Timeline

Jdlrobson created this task.Apr 1 2021, 11:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2021, 11:07 PM
Jdlrobson added a parent task: T278344: 1.36.0-wmf.38 deployment blockers.Apr 1 2021, 11:08 PM

(feel free to block 39 instead. Tackling logspam should be a priority of all teams within whatever capacity they can manage). Not sure if this has an user impact.

Zabe changed the subtype of this task from "Task" to "Production Error".Apr 2 2021, 10:20 AM
Cparle added subscribers: AnneT, egardner, Cparle.Apr 2 2021, 11:47 AM

@egardner @AnneT ... I suspect this might be from the calls to new mw.Title() in mediasearch-vue ... an Error gets thrown if the title string contains invalid characters. Might be better to use mw.Title.newFromText() instead, which doesn't throw an error but just returns an empty string if there's a problem

Krinkle updated the task description. (Show Details)Apr 2 2021, 10:57 PM
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.
Umherirrender added a project: JavaScript.Apr 4 2021, 8:13 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Apr 5 2021, 1:03 PM
CBogen moved this task from Incoming to Ready for Development on the Structured-Data-Backlog (Current Work) board.
AnneT claimed this task.Apr 5 2021, 1:42 PM
gerritbot added a comment.Apr 5 2021, 1:42 PM

Change 676931 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/extensions/WikibaseMediaInfo@master] Use mw.Title.newFromText to avoid errors

https://gerrit.wikimedia.org/r/676931

gerritbot added a project: Patch-For-Review.Apr 5 2021, 1:42 PM
AnneT moved this task from Ready for Development to Needs QA on the Structured-Data-Backlog (Current Work) board.Apr 5 2021, 3:38 PM

Thanks @Jdlrobson for identifying this and @Cparle for the info!

gerritbot added a comment.Apr 5 2021, 3:56 PM

Change 676931 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Use mw.Title.newFromText() to avoid errors

https://gerrit.wikimedia.org/r/676931

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 5 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 5 2021, 4:10 PM
Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Apr 7 2021, 1:17 AM
• dduvall edited parent tasks, added: T278345: 1.37.0-wmf.1 deployment blockers; removed: T278344: 1.36.0-wmf.38 deployment blockers.Apr 7 2021, 11:06 PM
Etonkovidova closed this task as Resolved.Apr 9 2021, 12:19 AM
Etonkovidova subscribed.

Checked in logstash wmf.38 - the error is not present anymore.

Krinkle moved this task from Mar 2021 to Apr 2021 on the Wikimedia-production-error board.Apr 9 2021, 12:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL