Page MenuHomePhabricator

Unable to parse title at new Title in Special:MediaSearch
Closed, ResolvedPublicPRODUCTION ERROR

Description

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.04.01?id=QsFmj3gBg_6mGHGhNnp7
example URL: https://commons.wikimedia.org/w/index.php?search=Go+down+to+the+man&title=Special:MediaSearch&go=Go&type=image

84 errors from multiple IP addresses in the last 3 hrs means this is notable enough to block the next deploy (or at very least the deploy after that)

error
Error: Unable to parse title
stack_trace
	
at new Title  <anonymous>:392:660
at a.displayName  URL1:538:603
at fn.get  <anonymous>:451:628
at fn.evaluate  <anonymous>:452:778
at a.displayName  <anonymous>:454:682
at a.eval  eval at Ya (:517:517), <anonymous>:3:239
at a.e._render  <anonymous>:460:348
at a.r  <anonymous>:493:746
at fn.get  <anonymous>:451:628
at new fn  <anonymous>:451:546

URL1: https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%7Cjquery.ui%7Cwikibase.mediainfo.mediasearch.vue&skin=vector&version=1pnkb

Related Objects

StatusSubtypeAssignedTask
ResolvedReleasejeena
ResolvedPRODUCTION ERRORAnneT

Event Timeline

(feel free to block 39 instead. Tackling logspam should be a priority of all teams within whatever capacity they can manage). Not sure if this has an user impact.

Zabe changed the subtype of this task from "Task" to "Production Error".Apr 2 2021, 10:20 AM

@egardner @AnneT ... I suspect this might be from the calls to new mw.Title() in mediasearch-vue ... an Error gets thrown if the title string contains invalid characters. Might be better to use mw.Title.newFromText() instead, which doesn't throw an error but just returns an empty string if there's a problem

Change 676931 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/extensions/WikibaseMediaInfo@master] Use mw.Title.newFromText to avoid errors

https://gerrit.wikimedia.org/r/676931

Change 676931 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Use mw.Title.newFromText() to avoid errors

https://gerrit.wikimedia.org/r/676931

Etonkovidova added a subscriber: Etonkovidova.

Checked in logstash wmf.38 - the error is not present anymore.