Page MenuHomePhabricator

Undo functionality not "sticking"
Closed, ResolvedPublic

Description

Behavior

  1. Visit the prototype: https://patchdemo.wmflabs.org/wikis/12cdbb1f7baf0b71e7dc733aff3da949/w/index.php/Talk:Main_Page
  2. Open by the Reply Tool by clicking any [ reply ] link that appears on the page
  3. Ensure you are in the Reply Tool's source mode and tools like pinging "@" and linking "🔗" are visible
  4. Type Hello
  5. Press + Z (for Mac users)
  6. Notice the text you typed in "Step 4." (Hello) disappears

Actual

  1. ❗️Notice the text you typed in "Step 4." (`Hello) remains in the live preview.

Expected

  1. ✅The live preview simply contains your signature.

  1. Switch to the tool's Visual mode

Actual

  1. ❗️Notice the text you typed in "Step 4." (`Hello) reappears

Expected

  1. ✅The tool's text input is empty

  1. Switch back to the tool's source mode

Actual

  1. ❗️Notice the text you typed in "Step 4." (Hello) reappears

Expected

  1. ✅The tool's text input is empty

Screen recording: https://youtu.be/ZIVy2a5gVBo .

Environment

  • OS: Big Sur (11.2)
  • Browser: Chrome (Version 89.0.4389.114)
  • Platform: desktop

Done

  • Tool is working as described in the "Expected" behavior sections of

Event Timeline

matmarex added subscribers: Esanders, matmarex.

I could reproduce this in the demo you linked, but not in the latest version of the code when testing locally (or this new demo I just made today: https://patchdemo.wmflabs.org/wikis/506b59600d/wiki/Talk:Main_Page).

So I looked through recently merged changes, and I found that this was fixed by this one: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/667357

Fix wikitext command registry inheritance

This fixes some missing commands in source mode, such as undo.

It seems that @Esanders has noticed and fixed it, and then completely forgot he did that. ;)

ppelberg updated the task description. (Show Details)

I could reproduce this in the demo you linked, but not in the latest version of the code when testing locally (or this new demo I just made today: https://patchdemo.wmflabs.org/wikis/506b59600d/wiki/Talk:Main_Page).

This seems to be fixed in the patchdemo linked above.

Although, the patchdemo linked above does not contain the new source mode where I originally observed this issue...does this matter, @matmarex ?

You can enable all features using ?dtenable=1, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page?dtenable=1

Appears to be working for me at that link

ppelberg claimed this task.
ppelberg added a project: Skipped QA.

You can enable all features using ?dtenable=1, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page?dtenable=1

Ah, noted. Thanks, Ed.

Appears to be working for me at that link

It is working for me here [i] as well.


i. https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page?dtenable=1