Page MenuHomePhabricator
Create Task
Maniphest T279151

Topic Subscriptions: Define copy and ensure consistent treatment across touchpoints for Notifications
Closed, ResolvedPublic
Actions

Description

Problem:

Notifications appear within the Echo dropdown, in email and as popup messages. What they say should be consistent. [i]

Requirements

  • The interface copy and QQQ messages defined in this spreadsheet are implemented.

Done

  • All possible "Touchpoints" are accounted for
  • The "Current copy" and "Revised copy" is defined for each touchpoint
  • ===Requirements are met

i.

Unusibscribe affordance + toastEcho notice
Screen Shot 2021-04-02 at 11.26.50 AM.png (349×306 px, 34 KB)
Screen Shot 2021-04-02 at 11.30.35 AM.png (266×542 px, 36 KB)

Details

SubjectRepoBranchLines +/-
Subscribe/unsubscribe with plain text linksmediawiki/extensions/DiscussionToolsmaster+489 -419
Customize query in gerrit

Related Objects
Search...

Event Timeline

• iamjessklein created this task.Apr 2 2021, 3:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2021, 3:32 PM
• iamjessklein claimed this task.Apr 2 2021, 4:53 PM
• iamjessklein added a project: Editing-team (Kanban Board).
• iamjessklein moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.Apr 2 2021, 4:56 PM
• iamjessklein mentioned this in T273911: Topic Subscriptions: Prototype Workflow .Apr 2 2021, 4:58 PM
• iamjessklein renamed this task from Topic Subscriptions: Choose a consistent style treatment for Notifications to Topic Subscriptions: Define copy and ensure consistent treatment across touchpoints for Notifications.Apr 2 2021, 5:12 PM
• iamjessklein updated the task description. (Show Details)
• ppelberg updated the task description. (Show Details)Apr 2 2021, 5:17 PM
• ppelberg added a parent task: T279164: Topic subscription: validate usability of topic subscription prototype with Juniors .Apr 2 2021, 5:31 PM
• ppelberg moved this task from Upcoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Apr 3 2021, 12:29 AM
• iamjessklein moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.Apr 6 2021, 4:46 PM
• iamjessklein updated the task description. (Show Details)Apr 6 2021, 4:52 PM

I updated the description card with the copy link for Echo and Email notifications.

• iamjessklein updated the task description. (Show Details)Apr 6 2021, 4:54 PM

I updated the description card with the copy link for toast messages.

• ppelberg mentioned this in T279498: [SPIKE] Determine how Topic Subscriptions and Watchlists relate in the near-term.Apr 7 2021, 2:41 AM
• iamjessklein moved this task from Doing to Ready to Be Worked On on the Editing-team (Kanban Board) board.Apr 7 2021, 4:59 PM
• iamjessklein moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.Apr 8 2021, 2:49 PM
• ppelberg added a comment.Apr 13 2021, 7:11 PM

13-April update
During today's team standup, we identified some additional "touchpoints" as needing to be "designed." These additional "touchpoints" are listed below.

I've also updated the task description's ===Notifications touchpoints + copy section.

  • Affordance in a section to which someone has NOT yet subscribed
  • Affordance in a section to which someone has attempted to subscribe
  • Affordance in a section to which someone has successfully subscribed
  • Affordance in a section to which someone has attempted to unsubscribe
  • Affordance in a section to which someone has successfully unsubscribed
• ppelberg updated the task description. (Show Details)Apr 13 2021, 7:12 PM
• iamjessklein added a comment.Apr 14 2021, 1:23 PM

I just want to clarify here that this ticket is about the language, and considering that this is a highly textual feature, I want us to use this ticket to gain consensus on the word choice here. If there are additional tweaks to the ux that need to be tweaked, I would prefer that we decouple them from this ticket.

• iamjessklein added a subscriber: Esanders.Apr 14 2021, 2:31 PM

Here is a first draft of the copy for Notifications.
@Esanders I have a few questions for you to answer in the "UX Notes" section.

• iamjessklein moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Apr 14 2021, 2:33 PM
• iamjessklein reassigned this task from • iamjessklein to Esanders.Apr 14 2021, 5:25 PM
• iamjessklein moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
• iamjessklein updated the task description. (Show Details)
• iamjessklein updated the task description. (Show Details)Apr 15 2021, 1:52 PM
• iamjessklein moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.

@Esanders and I did a final review, I am moving this over to Ready for Sign Off for @ppelberg to scan.

• ppelberg reassigned this task from Esanders to • iamjessklein.EditedApr 16 2021, 3:21 AM
• ppelberg moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
In T279151#7002764, @iamjessklein wrote:

@Esanders and I did a final review, I am moving this over to Ready for Sign Off for @ppelberg to scan.

Looks great, @iamjessklein. I posted one question for you to answer in the sheet here.

I default to you to make the final call on what I'm asking above.

Once you've arrived at a final opinion, can you please do the below?

  1. Comment it within the sheet
  2. Un-assign yourself from this task and
  3. Move this task to the "Ready to be worked on" column
• ppelberg updated the task description. (Show Details)Apr 16 2021, 3:23 AM
• iamjessklein closed this task as Resolved.Apr 16 2021, 6:05 PM
• iamjessklein moved this task from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (Kanban Board) board.

Note to engineer implementing this: Let me know if you have any questions.

• iamjessklein removed • iamjessklein as the assignee of this task.Apr 16 2021, 6:05 PM
• iamjessklein updated the task description. (Show Details)
• ppelberg reopened this task as Open.Apr 17 2021, 1:09 AM
• ppelberg updated the task description. (Show Details)

I'm re-opening this task considering the copy @iamjessklein defined in this spreadsheet has not yet been implemented.

• ppelberg mentioned this in T274278: Finalize topic subscription QQQ messages.May 5 2021, 1:36 AM
• ppelberg merged a task: T274278: Finalize topic subscription QQQ messages.
• ppelberg added subscribers: Valereee, Tacsipacsi, Parkywiki and 2 others.
gerritbot added a comment.Jun 1 2021, 3:46 PM

Change 685413 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Subscribe/unsubscribe with plain text links

https://gerrit.wikimedia.org/r/685413

gerritbot added a project: Patch-For-Review.Jun 1 2021, 3:46 PM
Esanders added a comment.Jun 1 2021, 3:46 PM

The main patch has been updated with the new copy: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/685413/5..6/i18n/en.json

Esanders moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Jun 1 2021, 3:47 PM
gerritbot added a comment.Jun 1 2021, 6:43 PM

Change 685413 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Subscribe/unsubscribe with plain text links

https://gerrit.wikimedia.org/r/685413

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2021, 7:10 PM
• LZaman mentioned this in T274188: Offer manual topic subscriptions as a Beta Feature at partner wikis.Jun 1 2021, 7:42 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 1 2021, 10:03 PM
matmarex subscribed.

Should be all done now.

• ppelberg moved this task from Ready for Sign Off to Code Review on the Editing-team (Kanban Board) board.Jun 2 2021, 4:57 PM
• ppelberg moved this task from Code Review to Design Review on the Editing-team (Kanban Board) board.
PatchDemoBot added a comment.Jun 4 2021, 3:40 PM

Test wiki created on Patch Demo by JKlein (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/91bccd4c6b/w/

• iamjessklein moved this task from Design Review to QA on the Editing-team (Kanban Board) board.Jun 4 2021, 3:44 PM

looks good +1

matmarex added a project: Editing QA.Jun 29 2021, 9:30 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Jul 22 2021, 1:59 AM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
• ppelberg closed this task as Resolved.Jul 26 2021, 11:31 PM
• ppelberg claimed this task.
PatchDemoBot added a comment.Jan 20 2022, 1:37 PM

Test wiki on Patch demo by JKlein (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/91bccd4c6b/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL