Page MenuHomePhabricator

Error: Unable to parse title in at wikieditor-toolbar-tool-file-insert
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: n/a

message
Error: Unable to parse title

Impact

Notes

Details

Request URL
n/a
Stack Trace
exception.trace
at Title URL1:1415:660
at wikieditor-toolbar-tool-file-insert URL2:62:765
at _createButtons/</props.click URL1:1285:531
at dispatch URL1:508:703
at add/elemData.handle URL1:505:359

URL1: https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.CodeMirror%2CTemplateWizard%2Ccharinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.CodeMirror.data%2Clib%7Cext.CodeMirror.mode.mediawiki%7Cext.TwoColConflict.JSCheck%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.echo.api%2Cinit%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery%2Cmoment%2Coojs%2Coojs-router%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Csuggestions%2CtextSelection%2Cthrottle-debounce%2Ctipsy%2Cui%7Cjquery.makeCollapsible.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Cicon%2CjqueryMsg%2Clanguage%2Cstorage%2Ctemplate%2Cuser%2Cutil%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.edit%7Cmediawiki.action.edit.collapsibleFooter%2CeditWarning%7Cmediawiki.language.specialCharacters%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%2Cicon%7Cmediawiki.widgets.DateInputWidget%2CUserInputWidget%2CvisibleLengthLimit%7Cmediawiki.widgets.DateInputWidget.styles%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-content%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-media%2Cicons-movement%7Cskins.vector.legacy.js%7Cuser.defaults%7Cwikibase.client.action.edit.collapsibleFooter&skin=vector&version=1besi
URL2: https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.wikiEditor&skin=vector&version=5s45r

Event Timeline

Relevant code:

https://gerrit.wikimedia.org/g/mediawiki/extensions/WikiEditor/+/a41070df0aeacb7b9621654cf890ca5409dd026a/modules/jquery.wikiEditor.dialogs.config.js#598

Looks like this accepts arbitrary user input, so it's a genuine bug that we fail to handle invalid inputs. Presumably if one tried to reproduce this in the WikiEditor file insertion dialog, one would find that the dialog crashes in some way.

Not logspam since the code has an obvious owner.

Change 683107 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiEditor@master] Swap new mw.Title to mw.Title.newFromText which handles invalid input

https://gerrit.wikimedia.org/r/683107

Change 683107 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Swap new mw.Title to mw.Title.newFromText to handle invalid input

https://gerrit.wikimedia.org/r/683107