Duplicate variant modals present upon upgrading to 6.8
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tsevener
	Apr 5 2021, 3:52 PM

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

Change your device languages to have multiple languages of the same Wiki. For example: English, Chinese Traditional, Chinese Simplified, Serbian, and Serbian (Latin).
Fresh install 6.7.4 from the App Store, launch the app and get to the Explore screen. Confirm in onboarding you see English, Chinese, and Serbian app languages selected.
Upgrade to TestFlight 6.8.0 (1802), launch app

Expected results

Upon launch, cycle through the variant modals by tapping the Got it button. You will see two identical Chinese modals and two identical Serbian modals.

Actual results

You should only see one modal per Wikipedia language, i.e. one Chinese and one Serbian in this case.

Environments observed

App version: 6.8.0 (1802)
OS versions: 14.4
Device model: iPhone 7
Device language: EN

Event Timeline

Tsevener created this task.Apr 5 2021, 3:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2021, 3:52 PM

Tsevener renamed this task from Bug - Duplicate variant onboarding modals present upon upgrading to 6.8 to Bug - Duplicate variant modals present upon upgrading to 6.8.Apr 5 2021, 3:53 PM

Tsevener updated the task description. (Show Details)

Tsevener renamed this task from Bug - Duplicate variant modals present upon upgrading to 6.8 to Duplicate variant modals present upon upgrading to 6.8.Apr 5 2021, 5:13 PM

James_Dempsey claimed this task.Apr 5 2021, 5:24 PM

At some point the results of the map were put into a Set to unique items, but that's not what ended up being committed.

This should be straightforward. I think I may unique another way though, so the languages remain in preferred user order.

James_Dempsey moved this task from Tasks from Product Backlog to Doing on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Apr 5 2021, 5:43 PM

James_Dempsey moved this task from Doing to Needs Code Review on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Apr 5 2021, 6:21 PM

LGoto triaged this task as High priority.Apr 5 2021, 6:37 PM

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

Tsevener moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Apr 5 2021, 7:48 PM

Tsevener moved this task from Waiting for Build to Needs QA on the iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower board.Apr 8 2021, 6:38 PM

Tsevener removed James_Dempsey as the assignee of this task.Apr 9 2021, 12:39 AM

Tsevener added a subscriber: James_Dempsey.

Looks good on 6.8.0 (1804)

Nice catch

Duplicate variant modals present upon upgrading to 6.8Closed, ResolvedPublicBUG REPORTActions